Closed
Bug 203300
Opened 21 years ago
Closed 21 years ago
fix rasdlg on MingW builds
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jonwil, Assigned: dmosedale)
References
Details
Attachments
(1 file)
|
1.67 KB,
patch
|
darin.moz
:
review+
bzbarsky
:
superreview+
sspitzer
:
approval1.4b+
|
Details | Diff | Splinter Review |
Rasdlg stuff is currently not working because the MingW w32api libraries dont have the needed definitions. Once the definitions are in, someone will need to fix the mozilla code.
|
Reporter | |
Comment 1•21 years ago
|
||
tihs compiles and runs (including the auto-dial stuff) using the rasdlg.h from w32api 2.3. Tested on Windows XP but assuming no bugs or problems in w32api and their rasdlg.h, it should work on all platforms.
|
|
Reporter | |
Updated•21 years ago
|
Attachment #121653 -
Flags: superreview?
Attachment #121653 -
Flags: review?(darin)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 121653 [details] [diff] [review] fix for this fine by me.. r=darin
Attachment #121653 -
Flags: review?(darin) → review+
|
|
Reporter | |
Updated•21 years ago
|
Attachment #121653 -
Flags: superreview? → superreview?(bzbarsky)
|
||
Updated•21 years ago
|
Attachment #121653 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Reporter | |
Updated•21 years ago
|
Attachment #121653 -
Flags: approval1.4b?
|
||
Comment 3•21 years ago
|
||
Comment on attachment 121653 [details] [diff] [review] fix for this a=sspitzer
Attachment #121653 -
Flags: approval1.4b? → approval1.4b+
|
|
Reporter | |
Comment 4•21 years ago
|
||
Patch checked in. Marking fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•