Closed Bug 203300 Opened 23 years ago Closed 23 years ago

fix rasdlg on MingW builds

Categories

(SeaMonkey :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jonwil, Assigned: dmosedale)

References

Details

Attachments

(1 file)

Rasdlg stuff is currently not working because the MingW w32api libraries dont have the needed definitions. Once the definitions are in, someone will need to fix the mozilla code.
Blocks: mingw
Attached patch fix for thisSplinter Review
tihs compiles and runs (including the auto-dial stuff) using the rasdlg.h from w32api 2.3. Tested on Windows XP but assuming no bugs or problems in w32api and their rasdlg.h, it should work on all platforms.
Attachment #121653 - Flags: superreview?
Attachment #121653 - Flags: review?(darin)
Comment on attachment 121653 [details] [diff] [review] fix for this fine by me.. r=darin
Attachment #121653 - Flags: review?(darin) → review+
Attachment #121653 - Flags: superreview? → superreview?(bzbarsky)
Attachment #121653 - Flags: superreview?(bzbarsky) → superreview+
Attachment #121653 - Flags: approval1.4b?
Comment on attachment 121653 [details] [diff] [review] fix for this a=sspitzer
Attachment #121653 - Flags: approval1.4b? → approval1.4b+
Patch checked in. Marking fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: