203324 - [cookies] backport phase 3 fixes to trunk

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[[e-mail]]

This is a spinoff from bug 200632. the phase 3 portion of the rewrite didn't
make it into 1.4b, and it contains some small fixes that should probably make it
into this release.

Comment 1

[[e-mail]]

Attachment: v1 patch

explanations, in order (most of this is copy/pasted from bug 200632):

1) removed a patch of dead code. this is live code in current trunk, but it's
really not necessary (must be leftover cruft) because we deal with null
aFirstURI in a graceful and correct manner. i must have missed deleting it at
an earlier stage, sorry...

2) make cookies not depend on the prefservice - if we can't get it, just use
some default values.

3) quieted a warning that we added in a while back - one of the cookie prefs is

optional, so pretty much everyone was seeing the warning "error reading cookie
prefs", which isn't good. so we just ignore the rv for that one pref.

4) fixed a minor list bug (sigh...) in RemoveExpiredCookies(). we need to
include session cookies in the search for the oldest one.

5) changed the mailnews check in a subtle way - we now check currentURI if
firstURI is null (previously we skipped all checks if firstURI was null).
shouldn't really make a difference to anything, just makes slightly more sense.


6) fixed a glaring omission in CheckPath() - we weren't getting the path from
the host before operating on it! that was stupid. (we didn't see this bug
because it's a rarely, if never, executed codepath).

Comment 2

[[e-mail]]

Attachment: v1 patch with "diff -w"

for reviewing convenience.

Comment 3

[[e-mail]]

Comment on attachment 121655 [details] [diff] [review]
v1 patch with "diff -w"

can i get some reviews here for 1.4b? ;)

(darin: this should be an easy one, because you've already reviewed all this in
phase 3.)

Comment 4

[Darin Fisher]

Comment on attachment 121655 [details] [diff] [review]
v1 patch with "diff -w"

yup sr=darin

Comment 5

[Alec Flett]

Comment on attachment 121655 [details] [diff] [review]
v1 patch with "diff -w"

sr=alecf

Comment 6

[Darin Fisher]

we want this for 1.4 beta...

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 121655 [details] [diff] [review]
v1 patch with "diff -w"

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 8

[[e-mail]]

checked in. thanks for the fast reviews!

Comment 9

[(not reading, please use [e-mail] instead)]

fixed, so clearing blocker request.