main program icon doesnt get pulled in properly with MingW builds

VERIFIED FIXED in mozilla1.5beta


UI Design
15 years ago
14 years ago


(Reporter: Jonathan Wilson, Assigned: jag (Peter Annema))


(Blocks: 1 bug)

Windows XP

Firefox Tracking Flags

(Not tracked)



(1 attachment)

4.40 KB, patch
Daniel (Leaf) Nunes
: review+
Brian Ryner (not reading)
: superreview+
Details | Diff | Splinter Review


15 years ago
Windres doesnt say anything so I dont know why its not being pulled into the
program properly.

Comment 1

15 years ago
I'd noticed this, but had assumed it had something to do with my
building/running problems. Seems I was wrong.
-> build config, at a guess
Assignee: asa → mozbugs-build
Component: Browser-General → Build Config
QA Contact: asa → granrose

Comment 3

15 years ago
-> XP Apps
Assignee: mozbugs-build → jaggernaut
Component: Build Config → XP Apps
QA Contact: granrose → paw
*** Bug 211794 has been marked as a duplicate of this bug. ***

Comment 5

15 years ago
If this is a WINDRES issue, which I'm not sure about, wasn't there going to be a
new release of WINDRES a while back?

Comment 6

15 years ago
Opened my MingW compiled mozilla.exe in Resource Hacker, and nothing appears.

Comment 7

15 years ago
The compiled resource file (whatever.res) is not being included when the program
is linked, and therefore is not being included in the compiled executables.  The
flag -mwindows should also be added so the programs are compiled as true Windows
programs (a console window won't appear when the program is run).  I've verified
these both myself by re-building mozilla.exe by hand (just modifying the command
make uses), but don't have the time to change the build system myself.

Comment 8

15 years ago
I do hope this gets fixed soon, as it's somewhat annoying not havng an icon in
my builds.

Comment 9

15 years ago
Created attachment 128793 [details] [diff] [review]


15 years ago
Attachment #128793 - Flags: superreview?(bryner)
Attachment #128793 - Flags: review?(leaf)

Comment 10

15 years ago
Comment on attachment 128793 [details] [diff] [review]

Attachment #128793 - Flags: review?(leaf) → review+
Attachment #128793 - Flags: superreview?(bryner) → superreview+

Comment 11

15 years ago
Patch has been checked in.
Last Resolved: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.5beta

Comment 12

15 years ago
Works with a 2003-08-04 CVS checkout

Comment 13

15 years ago
I now get an icon when building on Win XP using gcc. However, I don't get an
icon when building Firebird or Thunderbird. Is that the same issue, or should I
file a new bug on that?

Comment 14

15 years ago
Probably the same issue but definitely a different bug.  The makefiles for those
products were not updated.

Comment 15

15 years ago
Re my Comment #13.

Icons work for WIN32 Gcc builds of Mozilla, Thunderbird and Firebird as of 23/8/03.

Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.