Windres doesnt say anything so I dont know why its not being pulled into the program properly.
I'd noticed this, but had assumed it had something to do with my building/running problems. Seems I was wrong.
-> build config, at a guess
Assignee: asa → mozbugs-build
Component: Browser-General → Build Config
QA Contact: asa → granrose
-> XP Apps
Assignee: mozbugs-build → jaggernaut
Component: Build Config → XP Apps
QA Contact: granrose → paw
*** Bug 211794 has been marked as a duplicate of this bug. ***
If this is a WINDRES issue, which I'm not sure about, wasn't there going to be a new release of WINDRES a while back?
Opened my MingW compiled mozilla.exe in Resource Hacker, and nothing appears.
The compiled resource file (whatever.res) is not being included when the program is linked, and therefore is not being included in the compiled executables. The flag -mwindows should also be added so the programs are compiled as true Windows programs (a console window won't appear when the program is run). I've verified these both myself by re-building mozilla.exe by hand (just modifying the command make uses), but don't have the time to change the build system myself.
I do hope this gets fixed soon, as it's somewhat annoying not havng an icon in my builds.
Comment on attachment 128793 [details] [diff] [review] v1.0 r=leaf
Attachment #128793 - Flags: review?(leaf) → review+
Attachment #128793 - Flags: superreview?(bryner) → superreview+
Patch has been checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.5beta
Works with a 2003-08-04 CVS checkout
I now get an icon when building on Win XP using gcc. However, I don't get an icon when building Firebird or Thunderbird. Is that the same issue, or should I file a new bug on that?
Probably the same issue but definitely a different bug. The makefiles for those products were not updated.
Re my Comment #13. Icons work for WIN32 Gcc builds of Mozilla, Thunderbird and Firebird as of 23/8/03. Verifying...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.