Missing declaration in security/nss/lib/jar/jarevil.c

RESOLVED FIXED in 3.9

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: tenthumbs, Assigned: Robert Relyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

15 years ago
While building mozilla, gcc says

jarevil.c:345: warning: implicit declaration of function \
  `__CERT_AddTempCertToPerm'

Obviously missing a declaration somewhere.

Comment 1

15 years ago
Bob, could you take a look at this?  Seems that
we need to add __CERT_AddTempCertToPerm to nssrenam.h
and have jarevil.c include nssrenam.h before including
any other headers (at least before including certdb.h)?
Assignee: wtc → relyea
Priority: -- → P2
Target Milestone: --- → 3.9
Version: unspecified → 3.8
(Assignee)

Comment 2

15 years ago
Sounds like a reasonable thing to do. It's also pretty low priority (lib/jar is
only used for some NSS cmds).

bob
(Assignee)

Comment 3

15 years ago
Created attachment 132939 [details] [diff] [review]
Fix compilier warning in jarevil.c

Implemented Wan-Teh's suggestion
(Assignee)

Updated

15 years ago
Attachment #132939 - Flags: superreview?(jpierre)
Attachment #132939 - Flags: review?(wchang0222)

Comment 4

15 years ago
Comment on attachment 132939 [details] [diff] [review]
Fix compilier warning in jarevil.c

r=wtc.
Attachment #132939 - Flags: review?(wchang0222) → review+

Updated

15 years ago
Attachment #132939 - Flags: superreview?(jpierre) → superreview+
(Assignee)

Comment 5

15 years ago
Checking in jar/jarevil.c;
/cvsroot/mozilla/security/nss/lib/jar/jarevil.c,v  <--  jarevil.c
new revision: 1.7; previous revision: 1.6
done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

15 years ago
oops missing this cvs log.
cvs commit: Examining jar
Checking in nss/nssrenam.h;
/cvsroot/mozilla/security/nss/lib/nss/nssrenam.h,v  <--  nssrenam.h
new revision: 1.2; previous revision: 1.1

Comment 7

13 years ago
*** Bug 214204 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.