[classic,native] <menulist> display label truncated / cropped

VERIFIED FIXED

Status

SeaMonkey
Themes
VERIFIED FIXED
15 years ago
9 years ago

People

(Reporter: jag (Peter Annema), Assigned: jag (Peter Annema))

Tracking

(Blocks: 1 bug)

Trunk
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.65 KB, patch
shliang
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
(not reading, please use seth@sspitzer.org instead)
: approval1.4b+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
On Mac OS X in classic + native theme drawing, the <menulist>s become cropped
when their longest item is selected. See e.g. prefs -> appearance -> fonts ->
minimum font size, with "None" being cropped to "No..." and (same panel) ->
fonts for, select the longest menu item, see it get cropped.

Since on Mac OS X the menulist gets drawn slightly differently (the dropmarker
is drawn as part of the label instead of seperately), the dropmarker is taking
away space from the label. Suggested solution is to hide the dropmarker on Mac
OS X in the classic theme. Patch coming up.

See also bug 135089.
(Assignee)

Comment 1

15 years ago
Created attachment 121951 [details] [diff] [review]
Remove dropmarker from all menulists bug .menulist-compact
(Assignee)

Updated

15 years ago
Attachment #121951 - Flags: superreview?(bryner)
Attachment #121951 - Flags: review?(shliang)

Comment 2

15 years ago
See also bug 153737.
Comment on attachment 121951 [details] [diff] [review]
Remove dropmarker from all menulists bug .menulist-compact

assuming you've tested all of the different classes of menulist, sr=bryner.
Attachment #121951 - Flags: superreview?(bryner) → superreview+
Comment on attachment 121951 [details] [diff] [review]
Remove dropmarker from all menulists bug .menulist-compact

a=sspitzer, once you get r= from shuehan, and that you tested.	(please double
check some of the many menulists in mailnews)
Attachment #121951 - Flags: approval1.4b+
(Assignee)

Comment 5

15 years ago
Created attachment 122243 [details] [diff] [review]
Simpler fix, fixes bug in compact menulists

So we were actually displaying this button in compact menulists (I thought we
weren't... oops...), but as -moz-appearance: menulist-button, meaning we didn't
really draw anything there. Might as well not draw anything to begin with then.
Attachment #121951 - Attachment is obsolete: true

Comment 6

15 years ago
Comment on attachment 122243 [details] [diff] [review]
Simpler fix, fixes bug in compact menulists

r=shuehan
Attachment #122243 - Flags: review+
Comment on attachment 122243 [details] [diff] [review]
Simpler fix, fixes bug in compact menulists

sr/a=sspitzer
Attachment #122243 - Flags: superreview+
Attachment #122243 - Flags: approval1.4b+
(Assignee)

Comment 8

15 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Comment on attachment 121951 [details] [diff] [review]
Remove dropmarker from all menulists bug .menulist-compact

removing obsolete review request
Attachment #121951 - Flags: review?(shliang)

Updated

15 years ago
QA Contact: pmac → gbush

Comment 10

15 years ago
verified 6/11 build
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.