Closed
Bug 203723
Opened 21 years ago
Closed 21 years ago
Table cell data shifts out of table on indent
Categories
(Core :: DOM: Editor, defect, P1)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla1.5alpha
People
(Reporter: rubydoo123, Assigned: glazou)
Details
(Keywords: regression, Whiteboard: [adt2] editorbase+)
Attachments
(3 files)
1.29 KB,
text/html
|
Details | |
1.36 KB,
text/html
|
Details | |
720 bytes,
patch
|
KaiE
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
Tested using a build from 2003042808 on win2K 1. open composer 2. insert a table (4x4) 3. toggle to HTML Source (it's faster this way) and remove cellpadding, cellspacing, and style attributes; leave the border attribute 4. toggle back to Normal mode and select the upper left cell, enter the following: test[shift+enter]test. Enter some bogus text in a couple other cells. 5. set the caret after the first 'test' in the upper left cell and select the indent button. Actual results: the word is pulled out of the table cell and inserted above the table. Expected: the content of the cell to be indented Will attach a before and after test case
Reporter | ||
Comment 1•21 years ago
|
||
Reporter | ||
Comment 2•21 years ago
|
||
Comment 3•21 years ago
|
||
-->core confirmed on mac
Assignee: composer → jfrancis
Component: Editor: Composer → Editor: Core
Keywords: nsbeta1,
regression
OS: Windows 2000 → All
QA Contact: petersen → sairuh
Hardware: PC → All
Whiteboard: editorbase
Comment 4•21 years ago
|
||
adt: nsbeta1+/adt2
Comment 5•21 years ago
|
||
editorbase+. It is only present in CSS editing mode. -> Daniel
Assignee: jfrancis → glazman
Whiteboard: [adt2] editorbase → [adt2] editorbase+
Assignee | ||
Comment 6•21 years ago
|
||
confirmed, taking.
Severity: normal → major
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.5alpha
Assignee | ||
Comment 7•21 years ago
|
||
Hmmm.... This is VERY weird and seems related to range promotion or GetNodesForOperation. Still investigating.
Assignee | ||
Comment 8•21 years ago
|
||
Eheh, found the problem. My fault.
Assignee | ||
Comment 9•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #125072 -
Flags: superreview?(peterv)
Attachment #125072 -
Flags: review?(kaie)
Comment 10•21 years ago
|
||
Comment on attachment 125072 [details] [diff] [review] trivial fix I don't yet +fully* understand all the context code, but it seems to be reasonable based on explanations Daniel gave me on IRC. What convinced me most is that function WillHTMLIndent contains the same check, that this patch adds to WillCSSIndent. r=kaie
Attachment #125072 -
Flags: review?(kaie) → review+
Updated•21 years ago
|
Attachment #125072 -
Flags: superreview?(peterv) → superreview+
Assignee | ||
Comment 11•21 years ago
|
||
checked in, trunk
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•