All methods I had encountered thus far, had been of the type FUNC_DISPATCH. We're now encountering some FUNC_PUREVIRTUAL calls. So I'm adding FUNC_PUREVRITUAL and FUNC_VIRTUAL as allowable types.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.5alpha
Comment on attachment 122015 [details] [diff] [review] Allows FUNC_VIRTUAL and FUNC_PUREVIRTUAL I've not found anything that states I need to do anything different for functions marked with these other types of function. I thought I might have to pass "this" as a parameter or something, but it works fine without that. There's also FUNC_STATIC, but I think its best to ignore those for now. Surely that would be invoked differently.
Comment on attachment 122015 [details] [diff] [review] Allows FUNC_VIRTUAL and FUNC_PUREVIRTUAL sr=alecf
Attachment #122015 - Flags: superreview?(alecf) → superreview+
Comment on attachment 122015 [details] [diff] [review] Allows FUNC_VIRTUAL and FUNC_PUREVIRTUAL r=adamlock
Attachment #122015 - Flags: review?(adamlock) → review+
Patch checked in Leaving open for 1.4 branch check in (post Mozilla release)
Closing to get off 1.5a radar, though these should still be checked into 1.4 branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.