203951 - setting your default query to include boolean charts doesn't work.

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Todd Stansell]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; Q312461; YComp 5.0.2.4)
Build Identifier: 

If you build a complex query that includes boolean charts, and try to save it 
as your default query, it will save without problems.  However, when you go to 
the query page, the boolean chart section does not get restored to the saved 
settings.  Using a named query allows you to then "load" that query, which 
works fine.  Setting your default query to include boolean charts should work 
as well, however.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Max Kanat-Alexander]

You are indeed correct. I can confirm this on today's bugzilla-tip installation
on my local machine.

Confirmed Behavior: Boolean charts are not correctly created as part of a
(saved) default query.

-M

Comment 2

[Dave Miller [:justdave]]

I'm pretty sure this is fixed....  I think timeless reported it more recently
and cajoled someone into fixing it.  Anyone know where the original bug is?

Comment 3

[timeless]

*** This bug has been marked as a duplicate of 275019 ***

Comment 4

[Todd Stansell]

This is not actually a duplicate of bug 275019.  I verified that in 2.18 (which
includes the fix for bug 275019) that if you save a default query and include
boolean chart parameters, they will not be restored when you go back to the
query page to run your default query.  Reopening this bug.

Todd

Comment 5

[Todd Stansell]

Attachment: patch against tip

I've gone ahead and looked into the code myself.  I have implemented this same
fix against 2.18 for our use (using $::FORM variables instead of $cgi->param),
but here's is the equivalent patch for the tip.  I confirmed that this fixes
the bug for us.

Todd

Comment 6

[Frédéric Buclin]

Comment on attachment 196001 [details] [diff] [review]
patch against tip

joel, could you have a look at this patch?

Comment 7

[Wayne Mery (:wsmwk)]

joel, see comment 6 :)

Comment 8

[Frédéric Buclin]

Comment on attachment 196001 [details] [diff] [review]
patch against tip

Apollo 13: Houston?

Comment 9

[GavinS]

Attachment: Include boolean charts in stored default query, v2

I've updated the original patch - i hope that's OK.

There were 2 problems:

1) bitrot, 

2) The 'negate' boolean chart parameter was not included when loading the default query, so I added it

With those fixes, this patch works for me.

Comment 10

[Joel Peshkin]

Comment on attachment 276275 [details] [diff] [review]
Include boolean charts in stored default query, v2

Don't forget to fix up the comment to include 'negate' as well.

r=joel

Comment 11

[Frédéric Buclin]

a=me to land this patch on the trunk, but it has to wait till 3.0.2 is released before landing it on the 3.0.x branch. GavinS, can you confirm that your patch also works on 3.0? If not and you don't want to fix it on the 3.0 branch, please retarget the bug to 3.2 and remove the approval3.0 flag.

Comment 12

[Frédéric Buclin]

The patch applies cleanly and works fine on 3.0.2. a=me for 3.0.x.

Comment 13

[Frédéric Buclin]

tip:

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.175; previous revision: 1.174
done

3.0.2:

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.172.2.1; previous revision: 1.172
done