Closed
Bug 203979
Opened 23 years ago
Closed 23 years ago
leaking default encoder and all its encoders
Categories
(Core Graveyard :: Web Services, defect)
Core Graveyard
Web Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
Details
Attachments
(1 file)
|
1.96 KB,
patch
|
harishd
:
review+
jst
:
superreview+
asa
:
approval1.4+
|
Details | Diff | Splinter Review |
We use macros to create a whole gob of encoders for SOAP in
nsSOAPDefaultEncoder_1_1 and _1_2. They are all created with new and never get
recleaimed.
|
Assignee | |
Comment 1•23 years ago
|
||
with the patch for bug 203836 I introduced a leak of the default encoder itself.
So now I need to stop leaking the enclosing object as well.
Status: NEW → ASSIGNED
Summary: leaking encoders from the default encoder → leaking default encoder and all it's encoders
|
|
Assignee | |
Comment 2•23 years ago
|
||
Stops leaks.
|
|
Assignee | |
Comment 3•23 years ago
|
||
Comment on attachment 122898 [details] [diff] [review]
as snug as huggies
one line patch so we actually delete the nsDefaultEncoder instead of not.
Attachment #122898 -
Flags: superreview?(bryner)
Attachment #122898 -
Flags: review?(harishd)
Attachment #122898 -
Flags: approval1.4?
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: needs review/superreview/approval
Comment on attachment 122898 [details] [diff] [review]
as snug as huggies
r=harishd
Attachment #122898 -
Flags: review?(harishd) → review+
|
|
||
Updated•23 years ago
|
Whiteboard: needs review/superreview/approval → needs superreview/approval
|
|
Assignee | |
Updated•23 years ago
|
Attachment #122898 -
Flags: superreview?(bryner) → superreview?(jst)
|
||
Comment 5•23 years ago
|
||
Comment on attachment 122898 [details] [diff] [review]
as snug as huggies
Oh yeah, that would do it :-)
sr=jst
Attachment #122898 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: needs superreview/approval → needs approval
|
||
Comment 6•23 years ago
|
||
Comment on attachment 122898 [details] [diff] [review]
as snug as huggies
a=asa (on behalf of drivers) for checkin to 1.4.
Attachment #122898 -
Flags: approval1.4? → approval1.4+
|
|
Assignee | |
Comment 7•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: needs approval
|
||
Updated•23 years ago
|
Summary: leaking default encoder and all it's encoders → leaking default encoder and all its encoders
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•