20401 - Should display error/warning when create same server from the account wizard

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[Karen Huang]

Used WinNT 11-30-12-M12 & Linux 11-30-08-M12 commercila build,

Tried to Create the 2nd news server by using the same new server as the existing
one, should display error/warning to describe the new server already existed!

1) Be sure there was a news server there.
2) Tried to recreate the same news server as step (1) by using account wizard.
3) Actual Results: The news server which is same as existing one had been
created without error and also overwrite the existing one.

Expected results: Should display error/warning when created new server which
already existed, shouldn't overwrite the existing one.

Comment 1

[Phil Peterson]

I think it's legitimate to have more than one identity for the same server, but
I'm not sure if creating a new account is the right way to do that. Reassigning
to alecf.

Comment 2

[Alec Flett]

yep, though this bug is legit - it should at least warn the user.

Comment 3

[Phil Peterson]

Overwriting the existing account is a beta stopper

Comment 4

[Alec Flett]

*** Bug 41162 has been marked as a duplicate of this bug. ***

Comment 5

[Alec Flett]

this bug applies to all server types

Comment 6

[lchiang]

I think this should be a polish bug.  Nominate for nsbeta3.  Moving target 
milestone to M18 to correspond to the nomination.

Comment 7

[selmer (gone)]

Adding mail4 triage nomination keyword.

Comment 8

[lchiang]

Is this similar to http://bugzilla.mozilla.org/show_bug.cgi?id=29579?

+ per mail triage

Comment 9

[Karen Huang]

No. I think they are different.
bug 29579 is : created two different AOL accounts in one profile, this bug is 
creating exactly the same account again....Ccing nbaca.

Comment 10

[Ninoschka Baca]

I agree with Karen, they are different.

Comment 11

[lchiang]

to pdt: P1 because the existing account could be overwritten - data loss

Comment 12

[Phil Peterson]

PDT marking P2 and leaving [PDTP2]. Might be P1 if local data store was lost.

Comment 13

[(not reading, please use [e-mail] instead)]

taking this bug from alec.

Comment 14

[(not reading, please use [e-mail] instead)]

accepting.

Comment 15

[(not reading, please use [e-mail] instead)]

fix checked in.

I check if the proposed account exists when you hit "next" on the server page of
the new account wizard.  (the proposed account is the triplet
{username,hostname,type}).

if that account already exists, you don't go on to the next page of the new
account wizard.

Instead, an alert with the following text pops up:  "An account of this type
with the same username and hostname already exists.  Go back and change it or
hit cancel."

(adding jglick to the cc list so she can supply a better alert message.)

marking fixed.

Comment 16

[(not reading, please use [e-mail] instead)]

re-open.  I made it work properly for news, but not for mail servers.
I'll mark this fixed when I finish it.

Comment 17

[(not reading, please use [e-mail] instead)]

ok, now it's fixed.

we do the right thing for all the server types (nntp and pop/imap)

Comment 18

[Karen Huang]

Verified on WinNT 09-06-08-M18 commercial build IMAP, POP and NNTP accounts
Verified on Linux 09-06-08-M18 commercial build IMAP, POP and NNTP accounts
Verified on Mac 09-06-04-M18 commercial build IMAP, POP and NNTP accounts

An alert/warning "An account of this type with the same username and hostname 
already exists.  Go back and change it or hit cancel." is displaying now. 

jglick can still supply a better alert message if she wants. 
Marking as verifiied!!

Comment 19

[jglick]

cc'ing Robin Foster for wording issue.

Comment 20

[robinf]

Seth, can you re-word the error message as follows? Thanks.

A mail or newsgroup account with the same user name and server name already
exists. Click Back and enter a different server name, or click Cancel.

Comment 21

[(not reading, please use [e-mail] instead)]

the alert text has been updated to robinf's suggested text.