Build NSS on Solaris with -xO4 optimization

RESOLVED FIXED in 3.9

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Kirk Erickson, Assigned: Kirk Erickson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: 3.3.5)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

15 years ago
Chris, of the iWS team reported that there are no
known vulnerabilities compiling -xO4, and that the
webserver is being compiled with -xO4.

Pallab reported gains in iWS stress compiling NSS 
and NSPR -xO4.

I opened this bug to propose a patch for the TIP,
and subsequently NSS_3_3_BRANCH.

Note, currently we use -xO3. I will open a sister bug to
propose a similiar change in NSPR, shifting from -xO2 
to -xO4.
(Assignee)

Comment 1

15 years ago
Created attachment 122286 [details] [diff] [review]
Proposed patch for the TIP of NSS

Upgrades optimization level on Solaris from -xO3 to -xO4.
(Assignee)

Comment 2

15 years ago
Created attachment 122287 [details]
Selfserv Stress results

There's a gain at the TIP with this patch,
on both full handshakes and restarts.
(Assignee)

Updated

15 years ago
Attachment #122286 - Flags: review?(wtc)

Comment 3

15 years ago
Comment on attachment 122286 [details] [diff] [review]
Proposed patch for the TIP of NSS

r=wtc.
Attachment #122286 - Flags: review?(wtc) → review+

Comment 4

15 years ago
Kirk, could you provide the size information
of the NSPR and NSS .so's before and after
this change?
(Assignee)

Comment 5

15 years ago
Created attachment 122834 [details]
Selfserv Spress (with both NSS and NSPR -xO4)

Selfserv performance went up nicely when both NSS and
NSPR were compiled -xO4 (see runs with -both suffix).

NSS before (-xO3):
-rwxrwxr-x   1 ke119340 staff	   68596 May  8 22:45 libfort.so
-rwxrwxr-x   1 ke119340 staff	  314144 May  8 22:38 libfreebl_hybrid_3.so
-rwxrwxr-x   1 ke119340 staff	  275324 May  8 22:39 libfreebl_pure32_3.so
-rwxr-xr-x   1 ke119340 staff	  405148 Mar 27 03:41 libnspr4.so
-rwxrwxr-x   1 ke119340 staff	  756408 May  8 22:42 libnss3.so
-rwxrwxr-x   1 ke119340 staff	  313248 May  8 22:44 libnssckbi.so
-rwxr-xr-x   1 ke119340 staff	   42468 Mar 27 03:42 libplc4.so
-rwxr-xr-x   1 ke119340 staff	   17780 Mar 27 03:41 libplds4.so
-rwxrwxr-x   1 ke119340 staff	  266524 May  8 22:43 libsmime3.so
-rwxrwxr-x   1 ke119340 staff	  456572 May  8 22:40 libsoftokn3.so
-rwxrwxr-x   1 ke119340 staff	  208512 May  8 22:42 libssl3.so
-rwxrwxr-x   1 ke119340 staff	  160340 May  8 22:44 libswft.so

NSS after (-xO4)
-rwxrwxr-x   1 ke119340 staff	  142688 May  9 00:54 libfort.so
-rwxrwxr-x   1 ke119340 staff	  415968 May  9 00:43 libfreebl_hybrid_3.so
-rwxrwxr-x   1 ke119340 staff	  367776 May  9 00:45 libfreebl_pure32_3.so
-rwxr-xr-x   1 ke119340 staff	  427492 May  9 01:30 libnspr4.so
-rwxrwxr-x   1 ke119340 staff	  945852 May  9 00:50 libnss3.so
-rwxrwxr-x   1 ke119340 staff	  315276 May  9 00:53 libnssckbi.so
-rwxr-xr-x   1 ke119340 staff	   40112 May  9 01:30 libplc4.so
-rwxr-xr-x   1 ke119340 staff	   18204 May  9 01:30 libplds4.so
-rwxrwxr-x   1 ke119340 staff	  277484 May  9 00:52 libsmime3.so
-rwxrwxr-x   1 ke119340 staff	  547308 May  9 00:46 libsoftokn3.so
-rwxrwxr-x   1 ke119340 staff	  244240 May  9 00:51 libssl3.so
-rwxrwxr-x   1 ke119340 staff	  259784 May  9 00:54 libswft.so
Attachment #122287 - Attachment is obsolete: true
Setting to P2.  Kirk, if this is P1 for you, change it to P1 and set the target
milestone of the release for which you're going to check it in.
Priority: -- → P2
(Assignee)

Comment 7

15 years ago
Set target milestone to 3.9.
Note, the proposed patch works for NSS_3_3_BRANCH which
is another intended target of this change.
Target Milestone: --- → 3.9
(Assignee)

Comment 8

15 years ago
Checked into the TIP:
Checking in mozilla/security/coreconf/SunOS5.mk;
/cvsroot/mozilla/security/coreconf/SunOS5.mk,v  <--  SunOS5.mk
new revision: 1.13; previous revision: 1.12
done

Checked into NSS_3_3_BRANCH:
Checking in mozilla/security/coreconf/SunOS5.mk;
/cvsroot/mozilla/security/coreconf/SunOS5.mk,v	<--  SunOS5.mk
new revision: 1.7.2.2; previous revision: 1.7.2.1
done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

15 years ago
Whiteboard: 3.3.5
You need to log in before you can comment on or make changes to this bug.