Closed Bug 2041075 Opened 3 days ago Closed 2 days ago

Update PDF.js to new version 5a4d93a2387d310fde8f8b24bca894aebab50413 from 2026-05-20 13:49:01

Categories

(Firefox :: PDF Viewer, enhancement)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 2041423
Tracking Status
firefox153 --- affected

People

(Reporter: update-bot, Assigned: calixte)

References

(Blocks 1 open bug)

Details

(Whiteboard: [3pl-filed][task_id: PBsrhUuHTZGqAFaVtVD-cA])

Attachments

(1 obsolete file)

This update covers 3 commits. Here are the overall diff statistics, and then the commit information.


toolkit/components/pdfjs/PdfJsDefaultPrefs.js | 1 +
toolkit/components/pdfjs/content/build/pdf.mjs | 410 +++++++++++++-
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 6 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 3 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 60 +-
toolkit/components/pdfjs/content/web/viewer.css | 14 +-
toolkit/components/pdfjs/content/web/viewer.mjs | 62 +-
toolkit/components/pdfjs/moz.yaml | 4 +-
9 files changed, 534 insertions(+), 30 deletions(-)


957e004e38faa2f0175d905ef09fb3ee85347961 by Titus Wormer <tituswormer@gmail.com>

https://github.com/mozilla/pdf.js/commit/957e004e38faa2f0175d905ef09fb3ee85347961
Authored: 2026-03-26 12:14:14 +0100
Committed: 2026-05-19 21:10:12 +0200

Make text selection more visible (bug 1879559)

References https://bugzilla.mozilla.org/show_bug.cgi?id=1879559
(“In HCM, the text selection is barely visible”).

Continues work from @calixteman who had a partial patch.

This PR improves viewer text-selection highlighting by rendering
selection shapes in the draw layer.

  • add selection overlay rendering in the draw layer
    • significant code relates to selections spanning multiple text
      layers/pages, and edges/end-of-content boundaries
  • clear selection on rotate/scale/scroll/spread changes

My main question is: how should it appear?
I don’t have access to the Figma file linked on bugzilla.

In the CSS (draw_layer-builder.css) there are 3 blocks:

  • default
  • @supports for browsers supporting backdrop-filter
  • forced-colors mode

So it’s possible to design for those (or more).
Personally, the backdrop-filter: invert(1) is the most contrast,
so perhaps it’s better to use something else as the default,
and to use invert(1) if high contrast mode is used (maybe with a
prefers-contrast media query instead)?

Files Modified:

  • src/display/draw_layer.js
  • src/display/filter_factory.js
  • test/integration/text_layer_spec.mjs
  • web/annotation_editor_layer_builder.css
  • web/app.js
  • web/app_options.js
  • web/base_pdf_page_view.js
  • web/draw_layer_builder.css
  • web/draw_layer_builder.js
  • web/pdf_page_view.js
  • web/pdf_viewer.js
  • web/text_layer_builder.css

60591388a85499f3ff970522d98352dca15da8cc by Tim van der Meij <timvandermeij@gmail.com>

https://github.com/mozilla/pdf.js/commit/60591388a85499f3ff970522d98352dca15da8cc
Authored: 2026-05-19 20:16:32 +0200
Committed: 2026-05-19 21:07:26 +0200

Disable hardware acceleration for Chrome tests

This commit fixes the rendering issue that makes the "must update an
existing annotation" ink editor integration test permafail locally in
Chrome. Note that we already do this for Firefox tests, so this also
improves consistency between the two browsers.

Moreover, improve how we define Chrome options to (similar to their
Firefox counterparts) provide them in a single array, and document the
reasoning for why these options are being set more explicitly.

Fixes #21272.

Files Modified:

  • test/test.mjs

0d69cc4dcf368272d5122fe04c61ba390fcf06e0 by Tim van der Meij <timvandermeij@gmail.com>

https://github.com/mozilla/pdf.js/commit/0d69cc4dcf368272d5122fe04c61ba390fcf06e0
Authored: 2026-05-17 16:12:52 +0200
Committed: 2026-05-18 20:52:00 +0200

Introduce integration tests for the presentation mode functionality

This commit provides coverage for the happy flows of basic operations
like entering/exiting and changing pages.

Files Added:

  • test/integration/presentation_mode_spec.mjs

Files Modified:

  • test/integration/jasmine-boot.js

Duplicate of this bug: 2040954
Assignee: nobody → update-bot
Status: NEW → ASSIGNED

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: update-bot → cdenizet

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Status: ASSIGNED → RESOLVED
Closed: 2 days ago
Duplicate of bug: 2041423
Resolution: --- → DUPLICATE
Attachment #9588165 - Attachment is obsolete: true
No longer blocks: 1879559
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: