List marker glyphs 'disc' and 'circle' are diamond shaped

NEW
Unassigned

Status

()

Core
Layout
P4
trivial
15 years ago
8 years ago

People

(Reporter: mats, Unassigned)

Tracking

({testcase})

Trunk
Future
x86
Linux
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(9 attachments)

(Reporter)

Description

15 years ago
List marker glyphs 'disc' and 'circle' are diamond shaped when using certain
font sizes. This occurs at 14px and 15px but not with smaller or larger sizes.

Bug occurs with the following in my Preferences:
Proportional: Sans Serif        Size: 14
Sans-serif:   adobe-helvetica-iso8859-1


Bug occurs in 2003-04-30-22 trunk Linux.
(Reporter)

Comment 1

15 years ago
Created attachment 122254 [details]
Testcase #1
(Reporter)

Comment 2

15 years ago
Created attachment 122256 [details]
Screenshot of Testcase #1
(Reporter)

Updated

15 years ago
Keywords: testcase

Comment 3

15 years ago
Refer to bug 152588, comment 6.
Roland did some work at some point to make these draw better... so he may know
what's up.

Comment 5

15 years ago
Dupe of bug 152588 ?

See bug 152588, comment 6, which explains that they're not characters at all,
they're hand-drawn. I think the difference must be caused by the antialiasing of
the real Unicode-codepoints, or maybe one of their Truetype hints, which make
them better circles.

Comment 6

15 years ago
Can we somehow figure-out whether they are rendered as
a) as glyphs from a specific font
  OR
b) using home-grown code within Mozilla

If we use [b] then the code in
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsRenderingContextGTK.cpp#1110
should handle the case unless someone messed with the code that we do not use
the nsIRenderingContext::FillEllipse() codepath anymore.
They're done with FillEllipse last I checked.  See nsBulletFrame::Paint() for
details.

Comment 8

15 years ago
Boris Zbarsky wrote:
> They're done with FillEllipse last I checked.  See nsBulletFrame::Paint() for
> details.

Why does the code from
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsRenderingContextGTK.cpp#1110
then not kick-in and handle the problem ?!
You tell me.  :)  At most sizes it most certainly does.
(Reporter)

Comment 10

15 years ago
Created attachment 123832 [details]
Testcase #2
(Reporter)

Comment 11

15 years ago
Created attachment 123833 [details]
Testcase #3
(Reporter)

Comment 12

15 years ago
Created attachment 123834 [details] [diff] [review]
Patch

Fix nsRenderingContextGTK::FillEllipse/DrawEllipse for certain sizes
(Reporter)

Comment 13

15 years ago
Created attachment 123835 [details]
Screenshot of Testcase #2, before
(Reporter)

Comment 14

15 years ago
Created attachment 123836 [details]
Screenshot of Testcase #2, after
(Reporter)

Comment 15

15 years ago
Created attachment 123837 [details]
Screenshot of Testcase #3, before
(Reporter)

Comment 16

15 years ago
Created attachment 123838 [details]
Screenshot of Testcase #3, after
(Reporter)

Comment 17

15 years ago
A good way to compare the "before" and "after" screenshots is to load them
in separate tabs and then flip between them.

Updated

15 years ago
Priority: -- → P4
Target Milestone: --- → Future

Comment 18

13 years ago
*** Bug 293337 has been marked as a duplicate of this bug. ***
Assignee: layout → nobody
QA Contact: ian → layout
You need to log in before you can comment on or make changes to this bug.