Closed
Bug 2041757
Opened 2 months ago
Closed 1 month ago
Run newtab jest tests as part of node tests Tier 1 job
Categories
(Firefox :: New Tab Page, task)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We've begun a transition to using Jest for New Tab tests, as part of our larger React 19 upgrade / modernization project. This means that we're supposed to stop adding new Karma / Mocha tests, and focus on adding new Jest tests. There's a longer tail project to do that migration of tests, but for now, we've got this hybrid set of tests.
I found out yesterday that our Jest tests aren't actually being run in CI, which means that landings that fail those tests aren't being backed out by sheriffs. So far that hasn't really burned us yet, but as we add new tests and start using Jest more and more, it will.
We should make sure these tests are running in CI.
| Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/3ecfe42c2fb3
https://hg.mozilla.org/integration/autoland/rev/3981a3e5e42b
Run jest tests as part of newtab node tests in CI. r=home-newtab-reviewers,thecount
Comment 3•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in
before you can comment on or make changes to this bug.
Description
•