204191 - After installing the browser only option, I can no longer delete, rename, or move bookmarks in the Bookmark Manager

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Lutz Kotoll]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030401
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030501

When trying to organize bookmarks in the bookmark manager clicking-dragging an
item does change the mouse cursor appropriately but upon releasing the mouse
button the order of items is not changed. (The view setting is 'unsorted').

Reproducible: Always

Steps to Reproduce:
1. Go to Manage Bookmarks.
2. Depress left mouse button on an item in the list of bookmarks/folders/separators.
3. Drag the item to another position in the list. (Now the mouse cursor has
changed and is displayed as a sheet of paper with an angle to the upper left as
expected.) The new position in the list is shown with a short horizontal line as
expected.
4. Release the mouse button.
Actual Results:  
Nothing - except that the mouse cursor changed back to its normal form and the
line indicating the new position disappeared.

Expected Results:  
The chosen item should have been moved to the position indicated by the
horizontal line.

OS: Linux kernel 2.4.20, libc6 2.3.1, XFree86 xlibs 4.1, Debian
Mozilla Build ID: 2003050122

This happens with fresh installations via the net installer - option 'Browser
only'. The above tests were made directly after finishing installation while
browser window started by the installation process was still open (and still
running as root - yuk!). Not a single option within mozilla was changed. I also
made sure that the libraries found by ld.so were the ones just installed - not
those of another previously installed version.

I tested the same also with
- Mozilla Build ID 2003040105 (the announced 1.4a release) - SAME PROBLEM.
- Mozilla 1.3 (as downloaded from mozilla.org today) - NO PROBLEM.
- Mozilla 1.0.0 as distributed with Debian 'woody' - NO PROBLEM.
- even tried Phoenix 0.5 for comparison - NO PROBLEM.

(I was also trying to fiddle around with the 'move bookmark(s)' command from
both toolbar and edit menu of the bookmark manager and all I got was a tree view
of the bookmark folders but I couldn't move anything in there neither nor could
I get access to the individual bookmarks - it probably isn't intended that way,
is it?)

(I set the severity to 'major' - I hesitated to raise it up from 'normal' but
since there seems no other way to organize the bookmarks (other than 'vi ...'
:-) I feel it's apropriate.)

Comment 1

[Chris Petersen]

Hmm. Ok, I do see this problem only when installing the browser only as the
reporter. Drag and drop is falling when dragging bookmarks in the BK manager.
Tested with the 2003-05-19-08 Linux trunk build under RH 8.0.

Comment 2

[Chris Petersen]

When I install the browser only, I get the following problems:

1) I can't drag and drop any bookmarks in the Bookmark Manager
2) I can't drag and drop any links to the Personal Toolbar

However, dragging links from one browser window to another does function.

Comment 3

[Chris Petersen]

This regressed on the 2003-03-25-05 Linux trunk build. This problem only happens
when you install the browser only:

What Fails to work:

Drag and drop fails in Bookmark manager
Drag and drop fails on PT
Can't modify bookmarks in Bookmark manager (Delete, Rename, Properties)
Can't create a new separator or folder in Bookmark manager
Can't Move bookmarks to a new location
Can't create a new folder on PT

Comment 4

[Chris Petersen]

*** Bug 206256 has been marked as a duplicate of this bug. ***

Comment 5

[Chris Petersen]

*** Bug 207160 has been marked as a duplicate of this bug. ***

Comment 6

[Chris Petersen]

*** Bug 206641 has been marked as a duplicate of this bug. ***

Comment 7

[Jan Varga [:janv]]

Output from the JS console:
Error: [Exception... "Cannot find interface information for parameter arg 0
[nsIBookmarksService.transactionManager]"  nsresult: "0x80570006
(NS_ERROR_XPC_CANT_GET_PARAM_IFACE_INFO)"  location: "JS frame ::
chrome://communicator/content/bookmarks/bookmarks.js :: anonymous :: line 811" 
data: no]
Source File: chrome://communicator/content/bookmarks/bookmarks.js
Line: 811

Comment 8

[Jan Varga [:janv]]

reassigning

Comment 9

[Jan Varga [:janv]]

Attachment: patch

moved txmgr.xpt from [mail] to [browser] section

Comment 10

[Sean Su]

Comment on attachment 124331 [details] [diff] [review]
patch

it looks like packages-static-unix also needs the same change.
r=ssu once that's done.

Comment 11

[Jan Varga [:janv]]

Attachment: patch2

patch with ssu's suggestion

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 124341 [details] [diff] [review]
patch2

sr/a=sspitzer, assuming you've got all the right places, but since you have
discussed with packager expert ssu, I feel confident.

Comment 13

[Jan Varga [:janv]]

fixed on the trunk and 1.4 branch

Comment 14

[Chris Petersen]

Verified on both the branch (2003-05-29-12) and trunk (2003-05-29-14) builds.