Template builder enhancements

RESOLVED FIXED in mozilla1.4final

Status

()

Core
XUL
P3
normal
RESOLVED FIXED
15 years ago
10 years ago

People

(Reporter: janv, Assigned: janv)

Tracking

Trunk
mozilla1.4final
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

15 years ago
1. Template builder should rebuild its data after a batch operation
2. Template builder should notify listeners before and after calling Rebuild()
(Assignee)

Updated

15 years ago
Blocks: 204022
(Assignee)

Comment 1

15 years ago
Created attachment 122312 [details] [diff] [review]
patch
(Assignee)

Updated

15 years ago
Attachment #122312 - Flags: review?(jaggernaut)
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P3
Target Milestone: --- → mozilla1.4beta

Updated

15 years ago
Severity: normal → enhancement
Hardware: PC → All
(Assignee)

Updated

15 years ago
Severity: enhancement → normal

Comment 2

15 years ago
Comment on attachment 122312 [details] [diff] [review]
patch

>Index: content/xul/templates/public/nsIXULTemplateBuilder.idl
>===================================================================

>@@ -42,6 +43,7 @@
> #include "nsISupports.idl"
> #include "nsIRDFCompositeDataSource.idl"
> #include "nsIRDFResource.idl"
>+#include "nsIXULBuilderListener.idl"

interface nsIXULBuilderListener.idl

r=jag
Attachment #122312 - Flags: review?(jaggernaut) → review+

Comment 3

15 years ago
Without the .idl, of course
(Assignee)

Comment 4

15 years ago
+    RebuildAll();
...
+    return NS_OK;

should be:

+    nsresult rv = RebuildAll();
...
+    return rv;

Comment 5

15 years ago
Ah, yeah. r=jag with that change.
have you smoke tested the other consumers of templates?

(There's a ton of them in mailnews, for example).

mozilla/content/xul...this feels like something for hyatt to review?

if you can't get a review from hyatt, I'll do the sr.

looking at bonsai, jan's the only one to really do any hacking on
mozilla/content/xul in the past year.
(Assignee)

Comment 7

15 years ago
I found an issue in bookmarks JS code, C++ part of the patch is correct and we
still need it.
I'll try to fix the JS code and get review from Pierre.
(Assignee)

Comment 8

15 years ago
This becomes too much risky (more changes needed).
(Assignee)

Updated

15 years ago
Attachment #122312 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Target Milestone: mozilla1.4beta → mozilla1.4final
(Assignee)

Updated

15 years ago
Blocks: 205378
(Assignee)

Comment 9

15 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.