1. Template builder should rebuild its data after a batch operation 2. Template builder should notify listeners before and after calling Rebuild()
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P3
Target Milestone: --- → mozilla1.4beta
Comment on attachment 122312 [details] [diff] [review] patch >Index: content/xul/templates/public/nsIXULTemplateBuilder.idl >=================================================================== >@@ -42,6 +43,7 @@ > #include "nsISupports.idl" > #include "nsIRDFCompositeDataSource.idl" > #include "nsIRDFResource.idl" >+#include "nsIXULBuilderListener.idl" interface nsIXULBuilderListener.idl r=jag
Attachment #122312 - Flags: review?(jaggernaut) → review+
Without the .idl, of course
+ RebuildAll(); ... + return NS_OK; should be: + nsresult rv = RebuildAll(); ... + return rv;
Ah, yeah. r=jag with that change.
have you smoke tested the other consumers of templates? (There's a ton of them in mailnews, for example). mozilla/content/xul...this feels like something for hyatt to review? if you can't get a review from hyatt, I'll do the sr. looking at bonsai, jan's the only one to really do any hacking on mozilla/content/xul in the past year.
I found an issue in bookmarks JS code, C++ part of the patch is correct and we still need it. I'll try to fix the JS code and get review from Pierre.
This becomes too much risky (more changes needed).
Attachment #122312 - Attachment is obsolete: true
Target Milestone: mozilla1.4beta → mozilla1.4final
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.