2042496 - Fx wallpapers lack accessible names in Customize panel

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Natalie Stroud [:nstroud]]

Please note, this was tested and reported by a user that requires NVDA on Windows.

Prerequisites:

In about:config, set browser.newtabpage.activity-stream.nova.enabled to true

STR:

1. Open Firefox Nightly
2. Go to about:newtab
3. On the new tab page, navigate through the sections of articles (Popular Today, Politics, Entertainment, etc.) and follow and/or block topics to your liking.
4. Once you have the topics you want to view, open a story that interests you.
5. After opening an article, open a new tab to return to the new tab page.
6. Then, navigate to the shortcuts section and pin a shortcut you would visit a lot.
7. Navigate to a shortcut you don't need and dismiss it.
8. Lastly, select the Settings panel on the new tab page. With this panel open, you should toggle "Widgets" and "Wallpapers" on.
9. Then choose a wallpaper you'd like to use for your new tab page

Actual:

Video clip (SSO login is required to view)

This was found in Fable test MOZ-FBRHNT-3. The user has opened the Customize panel and wants to choose a wallpaper. He says to click Firefox, which opens a grid of multiple Firefox Kit wallpapers. As he navigates through the grid though, he finds the wallpaper controls are not labeled.

So these wallpapers are not... these checkboxes are not labeled and not accessible, so I don't actually know what I'm picking.

Expected:

The wallpapers require labels for screenreader users so they know what selection they're making

Comment 1

[Amber Meryman]

Related to: https://mozilla-hub.atlassian.net/browse/HNT-2604

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Reem Hamoui]

Attachment: WIP: Bug 2042496 - Update wallpaper selection for better screenreader accessibility.

Comment 5

[Phabricator Automation]

Comment on attachment 9637345 [details]
WIP: Bug 2042496 - Update wallpaper selection for better screenreader accessibility.

Revision D323962 was moved to bug 2070102. Setting attachment 9637345 [details] to obsolete.

Comment 6

[Reem Hamoui]

Attachment: Bug 2042496 - Add Fluent IDs for the Firefox wallpapers. r=#home-newtab-wattle-reviewers-rotation

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d437de69d3b3
https://hg.mozilla.org/integration/autoland/rev/49fd9384a13d
Add Fluent IDs for the Firefox wallpapers. r=fluent-reviewers,nina-py,bolsson

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/49fd9384a13d