clear saved form information doesn't empty formhistory.dat

VERIFIED FIXED

Status

()

Firefox
Address Bar
--
critical
VERIFIED FIXED
15 years ago
7 years ago

People

(Reporter: Jeremy M. Dolan, Assigned: Brian Ryner (not reading))

Tracking

({fixed-aviary1.0})

1.0 Branch
x86
Linux
fixed-aviary1.0
Points:
---
Bug Flags:
blocking-aviary1.0 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed by patch for 254485?)

(Reporter)

Description

15 years ago
In a profile with lots of form history saved, open prefs, and clear it.
Notice the button is greyed.
Quit Phoenix. Notice formhistory.dat grows by about 16K.
Restart Phoenix. Notice old form data not available in forms. Notice 'clear'
button still greyed.

It looks to me like Phoenix appended <datareference>=null on to the end of the
mdb file, instead of removing the old data.

This is a MAJOR privacy issue. Users will think their personal data has been
purged, as all UI indicates it has, while their data is actually still perfectly
readable in the mdb file.

Also probably a perf issue. I don't know if formhistory.dat will continue to be
appended to, or old entries will start to be overwritten.

Comment 1

15 years ago
Taking QA. Sorry for the bugspam
QA Contact: asa → davidpjames

Comment 2

14 years ago
This doesn't seem to exist any more. formhistory.dat looks empty to me 
following a clear all. 
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 3

14 years ago
Just tried this again, with
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040727 Firefox/0.9.1+

Pretty much the same as first described. formhistory.dat grew from 52k to 59k.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
could bug 254485 be related here?

Comment 5

14 years ago
(In reply to comment #4)
> could bug 254485 be related here?

or bug 253935...
(sairuh borrowing marcia's account)

could this be blocking bug 254485? nominating in case it does.
Assignee: hewitt → bryner
Blocks: 254485
Status: REOPENED → NEW
Flags: blocking-aviary1.0?

Comment 7

13 years ago
bryner is looking
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Version: unspecified → 1.0 Branch
the patch in bug 254485 might fix this one.

Updated

13 years ago
Whiteboard: fixed by patch for 254485?
Status: NEW → RESOLVED
Last Resolved: 14 years ago13 years ago
Resolution: --- → FIXED
looks fixed using 2004102109-0.9+ bits on linux fc2: formhistory.dat went from
27334 bytes to 245 bytes after I hit "clear," and remained as such after I had
quite firefox. marking verified.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Keywords: fixed-aviary1.0
You need to log in before you can comment on or make changes to this bug.