204398 - about:cache : "Inactive Storage" badly aligned

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[Jo Hermans]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030502

The row with 'Inactive Storage' is badly aligned compared with the 2 rows above
('Maximum storage size', and 'Store In Use'), because it's defined in a separate
table. See the code below.

I tried to find a duplicate, but I didn't find one.

<table>

<tr>
<td><b>Number of entries: </b></td>

<td><tt>333</tt></td>
</tr>

<tr>
<td><b>Maximum storage size: </b></td>
<td><tt>9216 k</tt></td>
</tr>

<tr>
<td><b>Storage in use: </b></td>
<td><tt>7641 k</tt></td>
</tr>

</table>
<table>
<tr><td><b>Inactive Storage:</b></td><td><tt> 7456 k</tt></td></tr>
</table>

Comment 1

[Boris Zbarsky [:bzbarsky]]

Applying my mind-reading powers to guess at what you really meant... :)

Comment 2

[Jo Hermans]

Attachment: screenshot

Damn, I wanted to write about:cache, but I wrote about:mozilla. Sorry. I just
ate too much yuka con carne :-)

Comment 3

[Adam Becevello]

I have a patch ready to go for this one...

Comment 4

[Adam Becevello]

Attachment: patch to fix alignment

Patch to fix alignment of 'Inactive storage' and 'Cache directory' in
about:cache

Comment 5

[Adam Becevello]

Comment on attachment 122461 [details] [diff] [review]
patch to fix alignment

Requesting review for patch to fix alignment of 'Inactive storage' and 'Cache
directory' in
about:cache

Comment 6

[Adam Becevello]

Comment on attachment 122461 [details] [diff] [review]
patch to fix alignment

Requesting review for a patch to fix incorrect alignment of 'Inactive storage'
and 'Cache
directory' in
about:cache

Comment 7

[Darin Fisher]

Comment on attachment 122461 [details] [diff] [review]
patch to fix alignment

>Index: mozilla/netwerk/protocol/about/src/nsAboutCache.cpp

>+        mBuffer.Append("</table>\n");
>+
>         mBuffer.Append("\n<br />");

nit: combine these two Append calls into one! ;-)

r=darin

Comment 8

[Adam Becevello]

Attachment: updated patch

Updated patch to address the nit darin had with the previous patch

Comment 9

[Adam Becevello]

Comment on attachment 123029 [details] [diff] [review]
updated patch

Requesting review and superreview for the updated patch.
Darin: I'm not sure if you have to review the patch again.  I'm asking again
just to be on the safe side.

Comment 10

[Darin Fisher]

Comment on attachment 123029 [details] [diff] [review]
updated patch

r=darin

Comment 11

[gordon]

I can r=gordon this, if we want darin to provide an sr=.

Comment 12

[Adam Becevello]

I'm fine with that arrangement.  Do you want me to change the requests in the
patch manager?

Comment 13

[gordon]

Sure.  Darin reads review requests more often than bug comments :-)

Comment 14

[Adam Becevello]

Comment on attachment 123029 [details] [diff] [review]
updated patch

I'm changing the requests for review and superreview again because gordon said
he would r= if darin did the sr= (see bug comments).  I'm hoping this will be
the last time I have to change these.

Comment 15

[gordon]

Comment on attachment 123029 [details] [diff] [review]
updated patch

r=gordon

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 123029 [details] [diff] [review]
updated patch

a=asa (on behalf of drivers) for checkin to 1.4.

Comment 17

[Adam Becevello]

Can someone please checkin this simple patch?
Thanks

Comment 18

[gordon]

Sure, I'll check it in this afternoon.

Comment 19

[gordon]

Patch checked in.  Marking FIXED.

Comment 20

[Jo Hermans]

verified as fixed in build 2003051408 on Mac OS X 10.2.6
thanks