Closed
Bug 204423
Opened 22 years ago
Closed 22 years ago
Remove unused nsIFindServiceConstructor, nsFindService::GetSingleton, nsFindService::FreeSingleton, empty nsFindModuleDtor
Categories
(SeaMonkey :: UI Design, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
2.31 KB,
patch
|
Brade
:
review+
sfraser_bugs
:
superreview+
sspitzer
:
approval1.4+
|
Details | Diff | Splinter Review |
/swap/BEOS/mozilla/xpfe/components/find/src/nsFindModule.cpp:11: warning: `nsresult nsIFindServiceConstructor(class nsISupports *, const struct nsIID &, void **)' defined but not used
Part of the big Find conspiracy (bugs 68307, 63241)
The function and the related methods weren't accessible from outside the find
module, which made them useless bloat. Consumers presumably have been using
xpcom's GetService method.
Attachment #122455 -
Flags: superreview?(sfraser)
Attachment #122455 -
Flags: review?(brade)
|
||
Updated•22 years ago
|
Attachment #122455 -
Flags: review?(brade) → review+
|
||
Updated•22 years ago
|
Attachment #122455 -
Flags: superreview?(sfraser) → superreview+
Comment on attachment 122455 [details] [diff] [review]
cleanout unused code
Free code savings win
(yes i don't care if it's approved)
Attachment #122455 -
Flags: approval1.4b?
|
||
Comment 3•22 years ago
|
||
Comment on attachment 122455 [details] [diff] [review]
cleanout unused code
1.4b is done. moving request forward.
Attachment #122455 -
Flags: approval1.4b? → approval1.4?
|
||
Comment 4•22 years ago
|
||
Comment on attachment 122455 [details] [diff] [review]
cleanout unused code
a=sspitzer
Attachment #122455 -
Flags: approval1.4? → approval1.4+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•