204574 - add states supports in accessibility/atk

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Bolian Yin]

Move over the code about states.

Comment 1

[Kyle Yuan]

I'm putting the email threads here:

> Do we have nsAccessible::GetAccExtState() before. Can we add it now to 
> support atk states. 
I don't object to this, though there are only 29 states in ATK. 

Aaron, how about using PRInt64 for accState like what ATK does?

Comment 2

[Aaron Leventhal]

If PRInt64 works, use it instead.

I've been told that it has problems. We should ask someone about that.

Comment 3

[Kyle Yuan]

Yes, it works. There are hundreds places used PRInt64 in mozilla code, for example:
http://lxr.mozilla.org/seamonkey/source/xpcom/components/nsComponentManager.cpp#1077

Comment 4

[Aaron Leventhal]

Great, use it.

I'm forgetting what I was told. Maybe it is not usable in interfaces or is not
scriptable? I don't see it in nsI*.h or nsI*.idl files.

Comment 5

[Aaron Leventhal]

Forget what I said, I was crazy/stupid.

You're right, I see it in many places.

Comment 6

[Bolian Yin]

Oh, PRUint64 cannot be const in idl.  So I cannot change extended state type
from "const unsigned long" to "const unsigned long long". 

Comment 7

[Bolian Yin]

Attachment: this patch use the old interface

Not change the interface, use the methods: GetAccState and GetAccExtState

Comment 8

[Kyle Yuan]

Comment on attachment 123744 [details] [diff] [review]
this patch use the old interface

r=kyle

Comment 9

[Bolian Yin]

checked in Trunk.