20459 - Small Frames

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[st8]

When doing <FRAMESET rows="0,..."  The zero size frameset always has size, only
about three or four pixels or so, but enough to be seen.  I think FRAMESET
cols=0,... is alright.

Comment 1

[karnaze (gone)]

Reassigning to Eric.

Comment 2

[Eric Pollmann]

See also related bug 21268

Comment 3

[ekrock's old account (dead)]

Ugly but not fatal to user experience. Moving to M16.

Comment 4

[Eric Pollmann]

We were doing the bad compatability math in nsFrameSetFrame::ParseRowColSpec.  
The fix is to change it from:
 if (i<=0) i=1 or i=100/count;
to:
 if (i<0) i=0;

I think it would be safe to fix this even for nav compatability mode, as I doubt 
any web sites depend on the old behaviour. :)  I'll walk the top 100 before 
checking this in though, of course.

Comment 5

[Eric Pollmann]

Attachment: Test case

Comment 6

[Eric Pollmann]

Fix checked in.  To verify, open up the test case, you should see the
mozilla.org web site.  There will be a slider bar along the very top, but zero
pixels of the other sites shown.  If you drag down, you'll see zdnet.com with a
slider bar along the very left edge, but zero pixels of the other site.

Thanks!

Comment 7

[Chris Petersen]

Fixed in the July 6th build.