Closed
Bug 204647
Opened 22 years ago
Closed 22 years ago
cannot build mac nullplugin when using --disable-oji
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4final
People
(Reporter: netscape, Assigned: sfraser_bugs)
Details
Attachments
(1 file, 1 obsolete file)
|
2.14 KB,
patch
|
peterlubczynski-bugs
:
review+
netscape
:
superreview+
asa
:
approval1.4+
|
Details | Diff | Splinter Review |
The build fails on the mac nullplugin when using --disable-oji.
|
Reporter | |
Comment 1•22 years ago
|
||
|
|
Reporter | |
Updated•22 years ago
|
Attachment #122600 -
Flags: superreview?(sfraser)
Attachment #122600 -
Flags: review?(peterl)
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 122600 [details] [diff] [review]
v1.0
>+#ifdef OJI
> if( navMinorVers >= NPVERS_HAS_LIVECONNECT )
> {
> pluginFuncs->javaClass = (JRIGlobalRef) Private_GetJavaClass();
> }
>+#endif
Probably want to have an #else that sets pluginFuncs->javaClass to null here.
Attachment #122600 -
Flags: superreview?(sfraser) → superreview+
|
|
Reporter | |
Comment 3•22 years ago
|
||
Attachment #122600 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•22 years ago
|
Attachment #122600 -
Flags: review?(peterl)
|
|
Reporter | |
Comment 4•22 years ago
|
||
Comment on attachment 122609 [details] [diff] [review]
v1.1
Transferring sr.
Attachment #122609 -
Flags: superreview+
Attachment #122609 -
Flags: review?(peterl)
|
|
||
Updated•22 years ago
|
Attachment #122609 -
Flags: review?(peterl) → review+
|
|
Reporter | |
Updated•22 years ago
|
Attachment #122609 -
Flags: approval1.4?
|
||
Comment 5•22 years ago
|
||
Comment on attachment 122609 [details] [diff] [review]
v1.1
a=asa (on behalf of drivers) for checkin to 1.4.
Attachment #122609 -
Flags: approval1.4? → approval1.4+
|
|
Reporter | |
Comment 6•22 years ago
|
||
Patch has been checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.4final
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•