User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.3) Gecko/20030312 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.3) Gecko/20030312 In the SearchDialog box (Ctrl+Shift+F), when you submit a search in the mails, the button to clic is "Search", and when the search is in progress, then the label of button is "Stop". In en-US, you can't see the problem, but for example in fr-FR, the two label are "Rechercher" and "Stop". As the first acceskey (for "Rechercher") is 'R', when the search is in progress, the label is "Stop(R)" ! Because the acceskey is not changed dynamicaly ! I can't solve the problem, but those files are useful : http://lxr.mozilla.org/mozilla/source/mailnews/base/search/resources/content/SearchDialog.js (line 170-177) http://lxr.mozilla.org/mozilla/source/mailnews/base/search/resources/content/SearchDialog.xul (line 90) http://lxr.mozilla.org/mozilla/source/mailnews/base/search/resources/locale/en-US/SearchDialog.dtd (line 7-8) Reproducible: Always Steps to Reproduce: 1. Open Mozilla Mail/News 2. Open the SearchDialog Box (Ctrl+Shift+F) 3. Make a search Note: Use an other language pack than en-US, for example fr-FR (www.frenchmozilla.org)
Created attachment 122694 [details] [diff] [review] proposed patch Added two accesskey properties in mailnews/base/search/resources/locale/en-US/search.properties and the relative js code in mailnews/base/search/resources/content/SearchDialog.js
Attachment #122694 - Flags: review?(ducarroz)
Attachment #122694 - Flags: review?(ducarroz) → review?(sspitzer)
testing, reviewing now. so far, looks good.
Assignee: naving → hugues.fournier
Target Milestone: --- → mozilla1.4final
Comment on attachment 122694 [details] [diff] [review] proposed patch this looks good
Created attachment 122753 [details] [diff] [review] patch your patch, plus some minor tweaks to prevent some js errors (not yours, just some long standing ones)
fixed in 1.4 final
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Keywords: access, nsbeta1
QA Contact: laurel → nbaca
Resolution: --- → FIXED
Asbin, can you let us know if this is working for you now?
I have tested the last patch, and it's working perfectly :) anything to add... ;-]
Marking Verified Fixed per Asbin's latest reponse. Thanks Asbin!
Status: RESOLVED → VERIFIED
Component: MailNews: Search → MailNews: Message Display
QA Contact: nbaca → search
You need to log in before you can comment on or make changes to this bug.