204765 - Parameterized properties expression don't return the assigned value

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[David Bradley]

When assigning a parameterized property the result of the expression is
undefined. It should be the value that was assigned.

Example:
typeof (obj.parameterizedProperty(5) = 50);

returns "undefined"

I don't think this is critical problem. We haven't encountered this pattern, but
I wanted to record the anomoly so it can be fixed for 1.5. I'm not sure if the
problem lies in XPConnect or JS, my bet is XPConnect at this point.

Comment 1

[David Bradley]

Attachment: Returns the proper value on assignment of a property

This returns back the property value when an assignment occurs.

Comment 2

[David Bradley]

Comment on attachment 125751 [details] [diff] [review]
Returns the proper value on assignment of a property

Looking for reviews for this patch. This addresses the property assignment not
"returning" the value assigned. It saves off the  the incoming JSVal, makes
sure it doesn't get collected and then puts it back into vp. The invoke that
occurs is generic and puts the result in vp. In this case IDispatch returns
nothing for assigning a property. So this is why we need to save off the value
and assign it on our way out.

Comment 3

[Adam Lock]

Comment on attachment 125751 [details] [diff] [review]
Returns the proper value on assignment of a property

r=adamlock

Comment 4

[Alec Flett]

Comment on attachment 125751 [details] [diff] [review]
Returns the proper value on assignment of a property

sr=alecf

Comment 5

[David Bradley]

Patch checked into trunk. Leaving open for possible consideration of the 1.4
branch later.

Comment 6

[David Bradley]

Closing to get off 1.5a radar, though these should still be checked into 1.4 branch.

Comment 7

[Phil Schwartau]

Rubber-stamp vrfy