204963 - memory leaks when PostEvent fails

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P3)

Description

[Darin Fisher]

there are a lot of places in necko and xpcom and probably others where errors
from PostEvent are not properly handled.  often times there is code like this:

  PLEvent *ev = new PLEvent;
  //...
  PL_InitEvent(ev, ...);
  
  if (eventQueue->PostEvent(ev) != PR_SUCCESS) {
    delete ev;
  }

on the surface this seems right, since the PLEvent was allocated using operator
new, but actually PL_InitEvent allocates other objects and hangs them off of the
PLEvent structure.  since PLEvent does not have a destructor, those allocates
are leaked when delete is used to cleanup the PLEvent.  the proper way to free a
PLEvent is to call PL_DestroyEvent.

i'm probably to blame for most of these leaks! ;-)

  ... but fortunately they should only really occur at shutdown.

Comment 1

[Doug Turner (:dougt)]

over to me.

Comment 2

[Jo Hermans]

this seems to be low-hanging fruit

Comment 3

[Doug Turner (:dougt)]

mass reassigning to nobody.

Comment 4

[Patrick McManus [:mcmanus]]

the necko post events look sane to me now.. generally they all use reference counted objects that do the right thing