Add ability to set the picture of the day as a custom wallpaper
Categories
(Firefox :: New Tab Page, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: maxx, Assigned: dgrant)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 2050973 - Picture of the Day: set the picture as the New Tab wallpaper. r?#home-newtab-reviewers
48 bytes,
text/x-phabricator-request
|
Details | Review |
Behavior: adds a "Set wallpaper" action to the populated widget. Because the
Merino image host sends no CORS headers, the picture bytes are fetched in the
main process (PictureOfTheDayFeed.setWallpaper): the feed verifies the response
is an image, derives a light/dark theme via calculateTheme, uploads it through
WALLPAPER_UPLOAD, and selects it as the custom wallpaper - the same end state as
a manual upload in the Customize panel. The button collapses to a confirmation
checkmark, and the "set as wallpaper" state clears when a different (non-custom)
wallpaper is chosen.
Risk: dispatches WALLPAPER_UPLOAD + newtabWallpapers.* SetPrefs to the existing
WallpaperFeed path; the main-process fetch avoids the content-process CORS
block; a non-ok / non-image response is rejected before upload. No metrics.yaml
change.
Validation: ./mach lint; newtab jest (PictureOfTheDay); xpcshell
test_PictureOfTheDayFeed.js (incl. non-image-response rejection). Bundle/CSS
regenerated at this commit.
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Updated•2 months ago
|
Comment 4•2 months ago
|
||
Comment 6•2 months ago
|
||
| bugherder | ||
Updated•1 month ago
|
Description
•