Closed Bug 2050973 Opened 2 months ago Closed 2 months ago

Add ability to set the picture of the day as a custom wallpaper

Categories

(Firefox :: New Tab Page, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: maxx, Assigned: dgrant)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.

Behavior: adds a "Set wallpaper" action to the populated widget. Because the
Merino image host sends no CORS headers, the picture bytes are fetched in the
main process (PictureOfTheDayFeed.setWallpaper): the feed verifies the response
is an image, derives a light/dark theme via calculateTheme, uploads it through
WALLPAPER_UPLOAD, and selects it as the custom wallpaper - the same end state as
a manual upload in the Customize panel. The button collapses to a confirmation
checkmark, and the "set as wallpaper" state clears when a different (non-custom)
wallpaper is chosen.

Risk: dispatches WALLPAPER_UPLOAD + newtabWallpapers.* SetPrefs to the existing
WallpaperFeed path; the main-process fetch avoids the content-process CORS
block; a non-ok / non-image response is rejected before upload. No metrics.yaml
change.

Validation: ./mach lint; newtab jest (PictureOfTheDay); xpcshell
test_PictureOfTheDayFeed.js (incl. non-image-response rejection). Bundle/CSS
regenerated at this commit.

Assignee: nobody → dgrant
Status: NEW → ASSIGNED
Attachment #9603709 - Attachment description: Bug 2050973 - Picture of the Day: set the picture as the New Tab wallpaper. r?#home-newtab-reviewers → Bug 2050973 - Picture of the Day: Set the picture as the New Tab wallpaper. r?#home-newtab-reviewers
Attachment #9603709 - Attachment description: Bug 2050973 - Picture of the Day: Set the picture as the New Tab wallpaper. r?#home-newtab-reviewers → Bug 2050973 - Picture of the Day: set the picture as the New Tab wallpaper. r?#home-newtab-reviewers
Attachment #9603709 - Attachment description: Bug 2050973 - Picture of the Day: set the picture as the New Tab wallpaper. r?#home-newtab-reviewers → Bug 2050973 - Picture of the Day: Set the picture as the New Tab wallpaper. r?#home-newtab-reviewers
Attachment #9603709 - Attachment description: Bug 2050973 - Picture of the Day: Set the picture as the New Tab wallpaper. r?#home-newtab-reviewers → Bug 2050973 - Picture of the Day: set the picture as the New Tab wallpaper. r?#home-newtab-reviewers

Backed out for causing node failures.

Push with failures

Failure log

Backout link

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Regressions: 2054104
Regressions: 2054106
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: