2050977 - Add telemetry to the Picture of the day widget

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Should follow standard widget telemetry:

• Impression
• Interaction
• Enabled
• Context menu items (esp the dismiss current photo)

Custom user events

• Set current photo as wallpaper
• Hide current photo
• (Optional??) Open up WikiMedia page

Comment 1

[dgrant]

Attachment: Bug 2050977 - Picture of the Day: telemetry test coverage and the interaction pref. r?#home-newtab-reviewers

The widget emits the standard unified widget events (widgets_impression,
widgets_user_event, widgets_enabled) via the shared useWidgetTelemetry hook,
wired alongside each feature: impression, enabled-on-hide, and user events for
set_wallpaper, hide_photo, manage_wallpaper, change_size, show_picture, and
learn_more. widget_name/user_action are free-form on the unified events, so no
metrics.yaml change is needed. This adds jest coverage asserting the enabled and
set_wallpaper events fire with widget_name="picture_of_the_day".

Validation: ./mach lint; newtab jest (PictureOfTheDay). Test-only.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/397fdcca79b3
https://hg.mozilla.org/integration/autoland/rev/34d168522672
Picture of the Day: telemetry test coverage and the interaction pref. r=Dre

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa3fdfe69b10
https://hg.mozilla.org/integration/autoland/rev/5ef54869fd53
Revert "Bug 2050977 - Picture of the Day: telemetry test coverage and the interaction pref. r=Dre"

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing node failures.

Push with failures

Failure log

Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ff07e36c3429
https://hg.mozilla.org/integration/autoland/rev/b2e9e8679973
Picture of the Day: telemetry test coverage and the interaction pref. r=Dre

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b2e9e8679973