Closed
Bug 2051742
Opened 3 months ago
Closed 1 month ago
Migrate New Tab ContextMenu/LinkMenu to panel-list
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
156 Branch
| Tracking | Status | |
|---|---|---|
| firefox156 | --- | fixed |
People
(Reporter: ini, Assigned: jbrown)
References
(Regressed 1 open bug)
Details
(Whiteboard: [hnt])
Attachments
(6 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
Currently topsites, story cards, and in-content ads all use the custom ContextMenu/LinkMenu for their '...' menus. We should look into migrating them over to the panel-list reusable component, like widgets already uses.
| Assignee | ||
Updated•3 months ago
|
Assignee: nobody → jbrown
Whiteboard: [hnt]
Updated•3 months ago
|
| Assignee | ||
Comment 1•3 months ago
|
||
| Assignee | ||
Comment 2•3 months ago
|
||
| Assignee | ||
Comment 3•3 months ago
|
||
| Assignee | ||
Comment 4•3 months ago
|
||
Updated•2 months ago
|
Attachment #9606466 -
Attachment description: WIP: Bug 2051742 - Extract shared logic/component for panel-list menus - r=#home-newtab-reviewers → Bug 2051742 - Extract shared logic/component for panel-list menus - r=#home-newtab-reviewers
Updated•2 months ago
|
Attachment #9606467 -
Attachment description: WIP: Bug 2051742 - Migrate in-content ad context menu to panel-list - r=#home-newtab-reviewers → Bug 2051742 - Migrate in-content ad context menu to panel-list - r=#home-newtab-reviewers
Updated•2 months ago
|
Attachment #9606468 -
Attachment description: WIP: Bug 2051742 - Migrate topsites context menu to panel-list - r=#home-newtab-reviewers → Bug 2051742 - Migrate topsites context menu to panel-list - r=#home-newtab-reviewers
Updated•2 months ago
|
Attachment #9606469 -
Attachment description: WIP: Bug 2051742 - Migrate story card context menu to panel-list - r=#home-newtab-reviewers → Bug 2051742 - Migrate story card context menu to panel-list - r=#home-newtab-reviewers
| Assignee | ||
Comment 5•2 months ago
|
||
| Assignee | ||
Comment 6•2 months ago
|
||
Pushed by jbrown@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/ecb88f3d9561
https://hg.mozilla.org/integration/autoland/rev/2bb0e3dc50b2
Extract shared logic/component for panel-list menus - r=maxx
https://github.com/mozilla-firefox/firefox/commit/1282df2de164
https://hg.mozilla.org/integration/autoland/rev/b49f29e6ffd2
Migrate in-content ad context menu to panel-list - r=ini
https://github.com/mozilla-firefox/firefox/commit/c983f853d323
https://hg.mozilla.org/integration/autoland/rev/443bdfc9eea4
Migrate topsites context menu to panel-list - r=maxx,ini
https://github.com/mozilla-firefox/firefox/commit/ad5afd6f5e03
https://hg.mozilla.org/integration/autoland/rev/7fc7a529176c
Migrate story card context menu to panel-list - r=maxx
https://github.com/mozilla-firefox/firefox/commit/e77e5cad2b7a
https://hg.mozilla.org/integration/autoland/rev/bb56d358e4b2
Migrate section context menu to panel-list - r=maxx
https://github.com/mozilla-firefox/firefox/commit/aa2778e2e44a
https://hg.mozilla.org/integration/autoland/rev/a2440e78bf11
Extract shared panel-list functions - r=maxx,ini
Comment 8•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2bb0e3dc50b2
https://hg.mozilla.org/mozilla-central/rev/b49f29e6ffd2
https://hg.mozilla.org/mozilla-central/rev/443bdfc9eea4
https://hg.mozilla.org/mozilla-central/rev/7fc7a529176c
https://hg.mozilla.org/mozilla-central/rev/bb56d358e4b2
https://hg.mozilla.org/mozilla-central/rev/a2440e78bf11
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox156:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 156 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c157/b156]
You need to log in
before you can comment on or make changes to this bug.
Description
•