[FIX]Cannot back to non-existant destination anchor after visiting another destination anchor

VERIFIED FIXED in mozilla1.5alpha

Status

()

Core
Document Navigation
P1
normal
VERIFIED FIXED
15 years ago
10 years ago

People

(Reporter: Jason Barnabe (np), Assigned: bz)

Tracking

({testcase})

Trunk
mozilla1.5alpha
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030510
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030510

Going to an URL with a destination anchor (A HREF="foo.html#Anchor") that is not
specified in that document (with A NAME) opens to the top of that page. If you
click on a valid destination anchor link, it'll take you to that spot on the
page. However, if you then click on the back button, it doesn't return to the
top of the page. Subsequent back clicks also do nothing.

Reproducible: Always

Steps to Reproduce:
1. Go to the link ("SARS" is not a named destination anchor on that page)
2. Click on "HIV".
3. Click back button
Actual Results:  
Nothing

Expected Results:  
Gone back to the top of the page.
(Reporter)

Comment 1

15 years ago
Created attachment 127215 [details]
part one of testcase
(Reporter)

Comment 2

15 years ago
Created attachment 127216 [details]
part two of testcase

Part one and part two must be together in the same folder. I don't think this
will work from Bugzilla.
(Reporter)

Updated

15 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: testcase
Taking.
Assignee: radha → bzbarsky
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.5alpha
Summary: Cannot back to non-existant destination anchor after visiting another destination anchor → [FIX]Cannot back to non-existant destination anchor after visiting another destination anchor
Comment on attachment 127217 [details] [diff] [review]
Proposed patch

The key here is not propagating the return value of GoToAnchor to our caller...
 The rest is minor cleanup.
Attachment #127217 - Flags: superreview?(dbaron)
Attachment #127217 - Flags: review?(jaggernaut)

Comment 6

15 years ago
Comment on attachment 127217 [details] [diff] [review]
Proposed patch

r=jag
Attachment #127217 - Flags: review?(jaggernaut) → review+
Attachment #127217 - Flags: superreview?(dbaron) → superreview+
Fixed.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

15 years ago
Verified fixed. Thanks.
Status: RESOLVED → VERIFIED

Updated

10 years ago
Component: History: Session → Document Navigation
QA Contact: chrispetersen → docshell
You need to log in before you can comment on or make changes to this bug.