2052965 - Policy: SearchEngines.PreventInstalls=true does not prevent manual adds in settings

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[thetfordb]

Attachment: Screenshot 2026-07-06 at 3.20.24 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:152.0) Gecko/20100101 Firefox/152.0

Steps to reproduce:

Configure SearchEngines.PreventInstalls=true.

Actual results:

The user is able to add a new search engine in Firefox -> Settings -> Search by clicking the "Add search engine" button.

Expected results:

The "Add search engine" button should not be visible or dimmed/inactive.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Settings UI' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 2052965 - SearchEngines.PreventInstalls should hide the add search engine button in settings and its context menu item. r?Standard8

Comment 3

[Mark Kennedy [:mark]]

Thanks Mike!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1f9e05dc72c7
https://hg.mozilla.org/integration/autoland/rev/01974b9d0091
SearchEngines.PreventInstalls should hide the add search engine button in settings and its context menu item. r=Standard8,mkennedy

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/01974b9d0091

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Bug 2052965 - SearchEngines.PreventInstalls should hide the add search engine button in settings and its context menu item.

Original Revision: https://phabricator.services.mozilla.com/D311883

Comment 7

[Phabricator Automation]

firefox-esr153 Uplift Approval Request

• User impact if declined/Reason for urgency: Policy fix - places for users to install search engines are still available.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Well tested and minor changes to Firefox code.
• String changes made/needed?: None
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/dd51eb262a48