Closed
Bug 205346
Opened 21 years ago
Closed 21 years ago
BeOS build warnings
Categories
(NSS :: Tools, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
3.9
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file, 1 obsolete file)
1.04 KB,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
/swap/BEOS/mozilla/security/nss/cmd/lib/secutil.c: In function `SECU_ErrorStringRaw': /swap/BEOS/mozilla/security/nss/cmd/lib/secutil.c:2498: warning: zero-length format string /swap/BEOS/mozilla/security/nss/cmd/lib/secpwd.c: In function `SEC_GetPassword': /swap/BEOS/mozilla/security/nss/cmd/lib/secpwd.c:91: warning: implicit declaration of function `isatty'
unistd.h defines isatty for BeOS; isatty isn't used in the other files so i'd suggest removing their prototypes.
Attachment #123019 -
Flags: review?(wtc)
Comment 2•21 years ago
|
||
Comment on attachment 123019 [details] [diff] [review] fix The declarations of the isatty prototype in keyutil.c and keystuff.c are for SunOS 4, whose system headers are missing a lot of declarations. Since we no longer support SunOS 4, it is not necessary to modify the code ifdef'd with SunOS 4. I will attach a new patch that also fixes the other compiler warning.
Attachment #123019 -
Flags: review?(wtc) → review-
Comment 3•21 years ago
|
||
Attachment #123019 -
Attachment is obsolete: true
Updated•21 years ago
|
Attachment #123039 -
Flags: review?(timeless)
Comment 4•21 years ago
|
||
Fix checked into the NSS tip (3.9). It is not necessary to backport the fix to any release branch because neither of the warnings is a bug. In particular, isatty() returns int, which is the return type of an undeclared C function.
Status: NEW → RESOLVED
Closed: 21 years ago
Component: Build → Tools
Resolution: --- → FIXED
Target Milestone: --- → 3.9
Comment on attachment 123039 [details] [diff] [review] fix v1.1 Posthumous r+ :) thanks for fixing the other warning, I had that somewhere. As for the other files, it just didn't seem like there was any reason for the declarations since the functions being decalred weren't being called. i suppose if at some later time someone did try calling them it would be best to have the declarations present.
Attachment #123039 -
Flags: review?(timeless) → review+
vrfy fixed (secpwd.c rev 1.12; secutil.c rev 1.45)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•