2053568 - Remove three unused activity-stream discoverystream.thumbsUpDown.* preferences

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filing as a good first bug to learn workflows.

The following about:newtab preferences (defined in browser/app/profile/firefox.js) are never read anywhere in the tree. They were the region/locale gating config for the story thumbs up/down buttons (bug 1909900, 2024), but their reader in browser/components/newtab/lib/ActivityStream.sys.mjs and the Nimbus mapping were dropped when newtab moved to browser/extensions/newtab/. The current PREFS_CONFIG and Nimbus FeatureManifest.yaml no longer reference them. Please remove their definitions.

• browser.newtabpage.activity-stream.discoverystream.thumbsUpDown.locale-thumbs-config
• browser.newtabpage.activity-stream.discoverystream.thumbsUpDown.region-thumbs-config
• browser.newtabpage.activity-stream.discoverystream.thumbsUpDown.searchTopsitesCompact

Link to the code:
https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#2074

To verify the fix:

• Confirm each pref has no remaining users by searching its name (and the sub-keys locale-thumbs-config, region-thumbs-config, searchTopsitesCompact) on https://searchfox.org (only the definition should match).
• Build the tree to make sure nothing breaks:
  ./mach build

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Nirmal Advani]

Attachment: Bug 2053568 - Remove unused locale-thumbs-config, region-thumbs-config, searchTopsitesCompact r=Sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7cceb7fba8be
https://hg.mozilla.org/integration/autoland/rev/93ebf9b3cb3e
Remove unused locale-thumbs-config, region-thumbs-config, searchTopsitesCompact r=thecount

Comment 3

[Nirmal Advani]

I think I made mistake with my git for author as it shows author Your Name <[e-mail]>. Is there a way to make correction or that boat has already sailed?

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/93ebf9b3cb3e

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/93ebf9b3cb3e

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/93ebf9b3cb3e

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/93ebf9b3cb3e