Closed
Bug 2053933
Opened 2 months ago
Closed 2 months ago
Add author and license attribution to picture of the day
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
154 Branch
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: maxx, Assigned: maxx)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
| Assignee | ||
Comment 1•2 months ago
|
||
Renders the attribution line under the title once a picture loads: the author
credit, a "Wikimedia Commons" link to the source page, and a link to the
license. The title uses newtab-picture-header-main (the shorter string from Bug
2053514); the author credit and the "Wikimedia Commons" link text are hardcoded
since nothing there is localizable. Also finishes the design-token cleanup that
removing the file-wide stylelint-disable exposed in the feed, description, and
set-wallpaper styles.
Updated•2 months ago
|
Assignee: nobody → mcrawford
Status: NEW → ASSIGNED
Pushed by mcrawford@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/1571ae33a537
https://hg.mozilla.org/integration/autoland/rev/7dfedf60331e
Picture of the Day: surface the author and license attribution. r=Dre
Pushed by csabou@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/e20ce970a07d
https://hg.mozilla.org/integration/autoland/rev/8f683cad639e
Revert "Bug 2053933 - Picture of the Day: surface the author and license attribution. r=Dre"
Comment 4•2 months ago
|
||
Flags: needinfo?(mcrawford)
Pushed by mcrawford@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/b9e3eb2c51ef
https://hg.mozilla.org/integration/autoland/rev/8dba47eb3acb
Picture of the Day: surface the author and license attribution. r=Dre
Comment 6•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
| Assignee | ||
Updated•2 months ago
|
Flags: needinfo?(mcrawford)
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in
before you can comment on or make changes to this bug.
Description
•