2054581 - ExternalComponentWrapper doesn't properly forward down "live" properties from MessageWrapper, like isIntersecting

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mike Conley (:mconley) (:⚙️)]

isIntersecting is a property from MessageWrapper here: https://searchfox.org/firefox-main/rev/d4ae522db3b933e502d1febec899e7955c1fb633/browser/extensions/newtab/content-src/components/MessageWrapper/MessageWrapper.jsx#22,30,141

and, perhaps unsurprisingly, is meant to be updated when the underlying message intersects the viewport.

Messages that are using Expo via ExternalComponentWrapper, (like asrouter-newtab-message and asrouter-multistage-message), only get this isIntersecting state sent down initially, when cloning the element here: https://searchfox.org/firefox-main/rev/d4ae522db3b933e502d1febec899e7955c1fb633/browser/extensions/newtab/content-src/components/MessageWrapper/MessageWrapper.jsx#140-147

ExternalComponentWrapper passes that along to the underlying external component being embedded, but does not forward updates to that property, meaning that asrouter-newtab-message and asrouter-multistage-message only get false set for isIntersecting initially, and never hear it being set to true!

Thankfully, nothing has truly relied on isIntersecting yet.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2054581 - Properly forward updating properties from MessageWrapper down through ExternalComponentWrapper down to wrapped message components. r?#home-newtab-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0ef390cc87b2
https://hg.mozilla.org/integration/autoland/rev/1428baa5376d
Properly forward updating properties from MessageWrapper down through ExternalComponentWrapper down to wrapped message components. r=jbrown

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1428baa5376d