2055211 - Don't cache HTTP errors in the module map

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Yoav Weiss]

Steps to reproduce:

The current spec behavior doesn't allow developers to retry failed module imports, as the failure result (either an HTTP error or a network failure) gets cached.

Expected results:

https://github.com/whatwg/html/pull/10327 fixes that. Browsers should implement that change

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Kershaw Chang [:kershaw]]

I assume the fix should be around js/loader/ModuleLoaderBase.cpp, so changing the component to JS.
Feel free to correct me if I am wrong. Thanks.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Yoshi: is this the right component for this one, or should we redirect this elsewhere?

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 2055211 - Part 1: Implement HTML PR #10327. r?jonco!

Don't cache modules with HTTP errors, this allows devs to retry the imports if
it was failed due to network failure.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 2055211 - Part 2: Update wpt ini files. r?jonco!

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 2055211 - Part 3: Update repeated-imports.any.js in text module. r?eemeli!

Re-import a network errored module should succeed now.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 2055211 - Part 4: Update /preload/modulepreload-sri-(importmap).html. r?jonco!

Make sure the <script> is inserted after <link rel="modulepreload"> is done,
so the result would be consistent.

Otherwise the <script> might also be preloaded by the speculative parser and
will join a single in-flight fetch with the <link>.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e43b0f7cf3e5
https://hg.mozilla.org/integration/autoland/rev/a15c4b8a74c1
Part 1: Implement HTML PR #10327. r=jonco
https://github.com/mozilla-firefox/firefox/commit/3c2347fd2d36
https://hg.mozilla.org/integration/autoland/rev/7aa823c607f0
Part 2: Update wpt ini files. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a31abd45a0ae
https://hg.mozilla.org/integration/autoland/rev/f90f44ab849f
Part 3: Update repeated-imports.any.js in text module. r=eemeli
https://github.com/mozilla-firefox/firefox/commit/219073d4f5e1
https://hg.mozilla.org/integration/autoland/rev/b9da6e4f2dc2
Part 4: Update /preload/modulepreload-sri-(importmap).html. r=jonco

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61626 for changes under testing/web-platform/tests

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a15c4b8a74c1
https://hg.mozilla.org/mozilla-central/rev/7aa823c607f0
https://hg.mozilla.org/mozilla-central/rev/f90f44ab849f
https://hg.mozilla.org/mozilla-central/rev/b9da6e4f2dc2

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx155 relnotes.