20554 - [DOGFOOD] adding attachments to a new msg, they don't show in the tree

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Scott MacGregor]

When composing a new message. If you add one or more attachments to the compose
window, none of them show up in the attachements pane.

As a result, it is impossible to be sure that your attachment is really there.
And you can't delete the attachment if you change your mind either because there
is nothing to select in the tree widget for attachments.

Apparently the attachment is still there though, it just isn't reflected in the
tree. If I send the message, I do get it with the attachments.

Comment 1

[lchiang]

*** Bug 20555 has been marked as a duplicate of this bug. ***

Comment 2

[Jean-Francois Ducarroz]

Something goes wrong with the tree used for displaying the attachments.
Hyatt, do you have any idea why the content created dynamically through JS doesn't show up anymore?

Comment 3

[leger]

Putting on PDT+ radar.

Comment 4

[David Hyatt]

Treecells are now boxes and can't contain raw text.  Make sure you do the
following... change

<treecell>blah</treecell>

to

<treecell value="blah"/>

Comment 5

[Jean-Francois Ducarroz]

Thanks for the tip, I'll give a try.

Comment 6

[Jean-Francois Ducarroz]

here is the fix:

S:\mozilla\mailnews\compose\resources\content>cvs diff MsgComposeCommands.js
Index: MsgComposeCommands.js
===================================================================
RCS file:
/cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v
retrieving revision 1.56
diff -r1.56 MsgComposeCommands.js
643d642
<               var text = document.createTextNode(attachment);
645c644
<               cell.appendChild(text);
---
>               cell.setAttribute("value", attachment);
672c671
<                               if (cell.childNodes &&  cell.childNodes.length)
---
>                               if (cell)
674,675c673,674
<                                       text = cell.childNodes[0];
<                                       if (text && text.data &&
text.data.length)
---
>                                       text = cell.getAttribute("value");
>                                       if (text.length)
678c677
<                                                       attachments = text.data;
---
>                                                       attachments = text;
680c679
<                                                       attachments =
attachments + "," + text.data;
---
>                                                       attachments =
attachments + "," + text;

Comment 7

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 8

[pmock]

Verified as fixed on win32, linux, and macos using the following builds:
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/1999-12-06-09-M12/sea
monkey32e.exe
ftp://sweetlou/products/client/seamonkey/unix/linux_glibc/2.2/x86/1999-12-06-08-
M12/netscape-i686-pc-linux-gnu.tar.gz
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-12-06-08-M12/netscap
e5-mac-M12.sea.bin

I verified that when attaching attachments, it shows up in the attachment area.
I also verified that I can select and remove attachments from the list.

Comment 9

[pmock]

Forgot to mention, that this fix worked under the plain text editor as well as
the rich text editor.