PK11_WaitForTokenEvent does not wait

RESOLVED FIXED in 3.8.1

Status

NSS
Libraries
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
This bug was introduced when we backported the NSS
3.7.x fixes on to the trunk before the NSS 3.8
release.

In the code
        if (timeout == PR_INTERVAL_NO_WAIT) {
            return waitForRemoval ? PK11TokenPresent : PK11TokenRemoved;
        }
we accidentally changed == to !=.  This means for any
nonzero timeout (timeout != PR_INTERVAL_NO_WAIT), we
return immediately.
(Assignee)

Comment 1

15 years ago
Created attachment 123217 [details] [diff] [review]
Proposed patch

This bug was introduced in rev. 1.56 of pk11slot.c.
The correct patch was already backported to the trunk
in rev. 1.54.  In rev. 1.56 we tried to backport that
patch again and patched the wrong part of the file.
(Assignee)

Comment 2

15 years ago
Fix checked into the tip (3.9) and the NSS_3_8_BRANCH (3.8.1).
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.8.1
(Assignee)

Updated

15 years ago
Attachment #123217 - Flags: review?(relyea)

Comment 3

15 years ago
Comment on attachment 123217 [details] [diff] [review]
Proposed patch

r=relyea

Updated

15 years ago
Attachment #123217 - Flags: review?(rrelyea0264) → review+
You need to log in before you can comment on or make changes to this bug.