2055942 - Remove version 145 train-hop shim for PrivacyFeed getTodayStats guard

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mike Conley (:mconley) (:⚙️)]

browser/extensions/newtab/lib/Widgets/PrivacyFeed.sys.mjs guards against older platforms whose PrivacyMetricsService (Bug 2010368) lacks getTodayStats. Now that Firefox 145 has long ago reached Release, we can remove the @backward-compat { version 145 } typeof lazy.PrivacyMetricsService?.getTodayStats !== "function" early-return in updateStats().

Comment 1

[Hackbot]

Attachment: Bug 2055942 - Remove version 145 train-hop shim for PrivacyFeed getTodayStats guard. r?#home-newtab-reviewers!

Firefox 145 has long since reached Release, so the @backward-compat { version 145 } early-return in PrivacyFeed.updateStats() — which guarded against older platforms whose PrivacyMetricsService (Bug 2010368) lacked getTodayStats — is no longer needed. getTodayStats is present in the current PrivacyMetricsService.sys.mjs.

Removes the guard and the now-obsolete test_backward_compat_guard xpcshell test that exercised it. The remaining PrivacyFeed xpcshell tests pass (24/24).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ca8d79506f2
https://hg.mozilla.org/integration/autoland/rev/dbfe4742fb48
Remove version 145 train-hop shim for PrivacyFeed getTodayStats guard. r=maxx

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dbfe4742fb48