205609 - control reaches end of non-void function GetSpecialSystemDirectory and lots of unhandled enumeration values

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

/swap/BEOS/mozilla/xpcom/io/SpecialSystemDirectory.cpp:
 In function `nsresult GetSpecialSystemDirectory(enum SystemDirectories, class nsILocalFile **)':
770: warning: enumeration value `OS_CurrentProcessDirectory' not handled in switch
770: warning: enumeration value `OS_CurrentWorkingDirectory' not handled in switch
770: warning: enumeration value `XPCOM_CurrentProcessComponentDirectory' not handled in switch
770: warning: enumeration value `XPCOM_CurrentProcessComponentRegistry' not handled in switch
770: warning: enumeration value `Moz_BinDirectory' not handled in switch
...
771: warning: control reaches end of non-void function `GetSpecialSystemDirectory(SystemDirectories, nsILocalFile **)'

Comment 1

[timeless]

Attachment: Hide warnings for nondebug and fix problem

Since developers might actually care about unhandled enumeration values i
wrapped the default case in an ifdef.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 123249 [details] [diff] [review]
Hide warnings for nondebug and fix problem

Get rid of the #ifndef DEBUG and r=.

Comment 3

[timeless]

checked in

Comment 4

[Mike Kaply [:mkaply]]

This broke OS/2. We can't find our system directory anymore.

Someone's not checking a return code...

See:

http://bugzilla.mozilla.org/show_bug.cgi?id=207081

This is the only checkin for that period of time.