Closed Bug 205609 Opened 22 years ago Closed 21 years ago

control reaches end of non-void function GetSpecialSystemDirectory and lots of unhandled enumeration values

Categories

(Core :: XPCOM, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

/swap/BEOS/mozilla/xpcom/io/SpecialSystemDirectory.cpp:
 In function `nsresult GetSpecialSystemDirectory(enum SystemDirectories, class nsILocalFile **)':
770: warning: enumeration value `OS_CurrentProcessDirectory' not handled in switch
770: warning: enumeration value `OS_CurrentWorkingDirectory' not handled in switch
770: warning: enumeration value `XPCOM_CurrentProcessComponentDirectory' not handled in switch
770: warning: enumeration value `XPCOM_CurrentProcessComponentRegistry' not handled in switch
770: warning: enumeration value `Moz_BinDirectory' not handled in switch
...
771: warning: control reaches end of non-void function `GetSpecialSystemDirectory(SystemDirectories, nsILocalFile **)'
Since developers might actually care about unhandled enumeration values i
wrapped the default case in an ifdef.
Attachment #123249 - Flags: review?(dougt)
Comment on attachment 123249 [details] [diff] [review]
Hide warnings for nondebug and fix problem

Get rid of the #ifndef DEBUG and r=.
Attachment #123249 - Flags: review?(dougt) → review+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
OS: BeOS → All
Hardware: PC → All
Resolution: --- → FIXED
This broke OS/2. We can't find our system directory anymore.

Someone's not checking a return code...

See:

http://bugzilla.mozilla.org/show_bug.cgi?id=207081

This is the only checkin for that period of time.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: