2056255 - Weather forecast widget SCSS has root level <hr> styles

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Maxx Crawford [:maxx]]

See https://searchfox.org/firefox-main/source/browser/extensions/newtab/content-src/components/Widgets/WeatherForecast/WeatherForecast.scss#319-323

These styles should be nested under .weather-forecast-widget, etc.

Comment 1

[BugBot [:suhaib / :marco]]

:rhamoui, since you are the author of the regressor, bug 2006525, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2006525

Comment 3

[Irene Ni [:ini]]

Attachment: Bug 2056255 - Remove root level <hr> styles from weather forecast widget. r=#home-newtab-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/baaa8caff48e
https://hg.mozilla.org/integration/autoland/rev/4735b8ae6d4f
Remove root level <hr> styles from weather forecast widget. r=maxx

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4735b8ae6d4f

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:ini, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox155 to wontfix.

For more information, please visit BugBot documentation.