2056300 - Expose available browser themes to New Tab and apply/install a selected theme

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

New Tab has no browser/lightweight-theme integration today. This bug adds the foundational parent-side bridge so New Tab content can (1) receive the list of available Nova themes plus the currently active theme, and (2) request applying/installing a selected theme.

Scope:

• New parent-side feed under browser/extensions/newtab/lib/ talking to the theme system (AddonManager / LightweightThemeManager).
• Action types and reducer state in common/Actions.mjs and common/Reducers.sys.mjs to deliver the theme list and active theme to content and to dispatch apply/install requests.
• No Customize Panel UI - that lands in the follow-up bugs.
• Full-panel title and back button

Comment 3

[Maxx Crawford [:maxx]]

Attachment: Bug 2056300 - Integrate the compact theme-picker into the New Tab customize panel r?#home-newtab-reviewers

Embed the reusable toolkit theme-picker element (compact layout) in the New Tab customize panel so users can switch their Firefox theme directly from Firefox Home.

• Render <theme-picker layout="compact" installsource="about:newtab"> in ContentSection, gated on the browser-wide browser.nova.enabled pref. PrefsFeed reads and observes that pref and broadcasts it to content as browserNovaEnabled; CustomizeMenu threads it through to ContentSection.
• Register the ThemePicker JSWindowActor for about:newtab and about:home so the element's remote controller can reach AddonManager/ThemesList via the parent in the content sandbox (about:home covers the startup-cache first tab).
• Load the theme-picker / moz-visual-picker / moz-segmented-control element modules in the live-rendered page (render-activity-stream-html.js) and the about:home startup-cache template (page.html.template) so the custom element is defined on both normal and cached pages.
• Add tests for the gate (ContentSection) and the pref observer/broadcast (PrefsFeed).

Comment 4

[Maxx Crawford [:maxx]]

Attachment: fixup! Bug 2056300 - Integrate the compact theme-picker into the New Tab customize panel r?#home-newtab-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6b1f2658d4ab
https://hg.mozilla.org/integration/autoland/rev/d2552e711a8e
Integrate the compact theme-picker into the New Tab customize panel r=Dre

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/60265b532094
https://hg.mozilla.org/integration/autoland/rev/f45836b3bd85
Revert "Bug 2056300 - Integrate the compact theme-picker into the New Tab customize panel r=Dre" for causing bc process crashes

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc process crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/f45836b3bd85da6c40b8113377efe4be75d40c38

Push with failures

Failures log ->PROCESS-CRASH | 6560c983-71f8-8466-e0d5-d2406ee73201 | Missing chrome or resource URLs: chrome://global/content/elements/moz-segmented-control.mjs [@ mozilla::net::CheckForBrokenChromeURL]

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/be9e02019a85
https://hg.mozilla.org/integration/autoland/rev/503206ab0dba
Integrate the compact theme-picker into the New Tab customize panel r=Dre

Comment 9

[agoloman]

Backed out for causing node failures.

• Backout link
• Push with failures
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c679cecab1ce
https://hg.mozilla.org/integration/autoland/rev/124bd6c2a9f4
Integrate the compact theme-picker into the New Tab customize panel r=Dre

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/124bd6c2a9f4