2056301 - Add New Tab Customize Panel browser theme selection strings

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Land the user-facing strings for the New Tab Customize Panel browser theme selection feature ahead of the UI so localization has lead time.

Strings to add in browser/locales/en-US/browser/newtab/newtab.ftl:

• Section title / toggle for the theme section
• Row picker labels (and any per-theme labels / alt text)
• Full-panel title and back button

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 2056301 - Add New Tab customize panel browser theme strings r?#fluent-reviewers

Comment 3

[Maxx Crawford [:maxx]]

Attachment: WIP: Bug 2056301 - Add additional New Tab customize panel browser theme strings

Comment 4

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/550e4d1b7515
https://hg.mozilla.org/integration/autoland/rev/158b13c2adf8
Add New Tab customize panel browser theme strings r=fluent-reviewers,bolsson

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/642bb59331d4
https://hg.mozilla.org/integration/autoland/rev/a4c0025724e9
Revert "Bug 2056301 - Add New Tab customize panel browser theme strings r=fluent-reviewers,bolsson" for causing bc process crashes

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc process crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/a4c0025724e9b72fe2294b8d86b40cf89ebf392c

Push with failures

Failures log ->PROCESS-CRASH | 6560c983-71f8-8466-e0d5-d2406ee73201 | Missing chrome or resource URLs: chrome://global/content/elements/moz-segmented-control.mjs [@ mozilla::net::CheckForBrokenChromeURL]

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/031d3978f5a1
https://hg.mozilla.org/integration/autoland/rev/5c274d9805b1
Add New Tab customize panel browser theme strings r=fluent-reviewers,bolsson

Comment 9

[agoloman]

Backed out for causing node failures.

• Backout link
• Push with failures
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1003ece1c29
https://hg.mozilla.org/integration/autoland/rev/714f7a5b98e3
Add New Tab customize panel browser theme strings r=fluent-reviewers,bolsson

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/714f7a5b98e3