2056304 - Add full browser theme selection sub-panel to the New Tab Customize Panel

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Add the full browser theme selection sub-panel to the New Tab Customize Panel, following the management-panel pattern (WidgetsManagementPanel.jsx / SectionsMgmtPanel.jsx): a moz-box-button opens a sliding full all-themes sub-view.

Scope:

• New management panel component under components/CustomizeMenu/ (or the Nova path).
• Sub-panel visibility state in Base.jsx (mirroring showWidgetsManagementPanel), threaded through CustomizeMenu -> ContentSection.
• CSSTransition + onSubpanelToggle slide coordination.
• Opened from the row picker see-all entry point.
• Wire to the redux theme data from bug 2056300.

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 2056304 - Add the full browser theme selection panel to the New Tab customize panel r?#home-newtab-reviewers

Wire the existing "See more themes" button in the customize panel's Appearance section to a new full theme selection sub-panel.

• New ThemesManagementPanel (mirrors WidgetsManagementPanel): the box-button opens a sliding sub-panel with a back button ("Firefox Themes" title), the full-layout theme-picker (Light/Dark/Device chooser + all themes), and a moz-box-link out to the about:addons themes list.
• Panel visibility state (showThemesPanel / toggleThemesPanel) lives in Base and is threaded through CustomizeMenu to ContentSection.
• OPEN_ABOUT_ADDONS_THEMES action + AboutPreferences handler open addons://list/theme via BrowserAddonUI.openAddonsMgr.
• Load the moz-box-link element module in the prerendered and startup-cache HTML; reuse the mgmt-panel slide styles for .themes-mgmt-panel.
• Tests for the panel and appearance section; Karma coverage override for the Jest-tested panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/35da6586e8d5
https://hg.mozilla.org/integration/autoland/rev/a0ea4cfa1964
Add the full browser theme selection panel to the New Tab customize panel r=Dre

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7103dc909fa7
https://hg.mozilla.org/integration/autoland/rev/1224407227ad
Revert "Bug 2056304 - Add the full browser theme selection panel to the New Tab customize panel r=Dre" for causing bc process crashes

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc process crashes

Backout link: https://hg.mozilla.org/integration/autoland/rev/1224407227adc1e32da568def63d1100ba2c3223

Push with failures

Failures log ->PROCESS-CRASH | 6560c983-71f8-8466-e0d5-d2406ee73201 | Missing chrome or resource URLs: chrome://global/content/elements/moz-segmented-control.mjs [@ mozilla::net::CheckForBrokenChromeURL]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8497057983d0
https://hg.mozilla.org/integration/autoland/rev/f028a7975d26
Add the full browser theme selection panel to the New Tab customize panel r=Dre

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/207427403d8c
https://hg.mozilla.org/integration/autoland/rev/1a56223e34e7
Revert "Bug 2056304, Bug 2056300, Bug 2056301 - Add the full browser theme selection panel to the New Tab customize panel r=Dre"

Comment 7

[agoloman]

Backed out for causing node failures.

• Backout link
• Push with failures
• Failure Log

Comment 8

[Maxx Crawford [:maxx]]

Trying again! Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5505a6ac604d
https://hg.mozilla.org/integration/autoland/rev/5088d5016a6e
Add the full browser theme selection panel to the New Tab customize panel r=Dre

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5088d5016a6e