205662 - memory no longer released on closing images

Status: VERIFIED DUPLICATE of bug 198806

(Core :: Graphics: ImageLib, defect)

Description

[Steffen Motzer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030513 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030513 Mozilla Firebird/0.6

When I open a couple of images Mozilla / Mozilla Firebird allocates the memory
needed for the images. After closing the tabs Mozilla no longer releases the
memory. This problem was reintroduced the between build 04/11 and build 04/22.
Mozilla only seems to fail to release the memory if image resizing is turned off
or if I save the image before closing the tab.


Reproducible: Always

Steps to Reproduce:
1. Disable image resizing.
2. Open many images (in tabs) and save them.
3. Close the tabs.

Actual Results:  
Mozilla no longer releases the memory.

Expected Results:  
Mozilla should have relased the memory.

Comment 1

[Jim Dunn]

cc'ing gordon, just because

Comment 2

[Jim Dunn]

Gordon, is this working as designed?
What I see on 1.4b is that memory cache is fixed at some 
determined # (on my win2k box it is 31744 k.  The system
  memory usage is at X 
  I start mozilla 1.4b, memory usage goes up 2-10k (X + 10k)
  I load a TON of images in a tab, memory usage goes up 75k (X + 10K + 75K)
  I close the tab, memory usage goes to (X + 10K + 31k)
  closing mozilla, memory usage goes to X

So this seems to be working correctly.

Steffen, if you want can you do something similar, 
What is your memory cache maximum set at (about:cache?device=memory)
what is memory usage before mozilla is run
what is memory usage with mozilla about:blank
what is memory usage when you load a ton of images in tabs
what is memory usage if you close everything about about:blank

Comment 3

[gordon]

Jim, yes that sequence of memory usage looks correct.  The memory cache can grow
beyond its limit with actively 'in use' entries.  When the entries are no longer
referenced the cache goes back down to its normal limit.

However, this sounds like a duplicate of bug 198806.  The new piece of info is
that bit about turning image resizing off.

Comment 4

[Steffen Motzer]

Before I start MozillaFirebird      :  82192K
After starting Mozilla (about:blank):  91000K
After loading testpage              :  95276K
After loading 32 images in tabs     : 213696K

After closing all tabs except the about:blank tab the memory usage stays at
approximately 213M.

Memory cache device after closing the 32 tabs:
Number of entries: 	135
Maximum storage size: 	18432 k
Storage in use: 	90595 k
Inactive Storage: 	0 k

Memory cache device after clearing the cache:
Number of entries: 	6
Maximum storage size: 	18432 k
Storage in use: 	57 k
Inactive Storage: 	52 k

Even after clearing the cache the memory usage does not go down !

Comment 5

[Steffen Motzer]

I just installed Mozilla 1.5 and this SERIOUS memory leak I reported five months
ago is obviously not fixed :( After using Mozilla 1.5 for a couple of minutes it
had already leaked 150 megabytes! The only way to release the memory is to close
Mozilla.

Comment 6

[Darin Fisher]

this is not a blocker bug.  please do not set that severity unless you know what
it means.  blocker status implies that the bug prevents mozilla from being used
by developers.  clearly this bug does not fall into that category.

also, please download and test a recent trunk build.  it would be much more
beneficial to the developers to have information about the current development
builds.  thx!

Comment 7

[Steffen Motzer]

I did download a recent nightly build before installing Mozilla 1.5 . I just
downloaded build 2003101704 and that build leaks a lot of memory too.

If an image is saved then the memory of the decoded image (the bitmap) will
never be released.

Comment 8

[Darin Fisher]

steffen: can you please list the exact steps required to reproduce that leak?
give me all the gory step-by-step details! ;-)

like, open mozilla, open one tab, load this URL, open another tab, load this
URL, etc.  i need to be able to reproduce exactly what you are seeing.  thx!

Comment 9

[Steffen Motzer]

Okay, the leak can be reproduced this way:

1. download this image:

http://astrogeology.usgs.gov/Gallery/ImageGallery/large/MarsPathfinderPan.jpg

2. make some (i.e. 10) copies of this file: 01.jpg, 02.jpg, 03.jpg ...
3. start Mozilla (Windows 2000 SP4) and drag and drop the folder that contains
these copies onto Mozilla
4. open the task manager so that you can always see the graph of the memory used
by Windows
5. cofigure Mozilla so that a new tab will be opened on Control+click
6. hold the control key and open the copies of the downloaded image in new tabs 
7. you can see that Mozilla allocates the memory for these images
8. go to each tab, save the image (Control+S) and close the tab
9. Mozilla does not release the memory if the image was saved. If the tabs are
closed without saving the images then the memory does get relased

Comment 10

[Jim Dunn]

Steffen based on your latest comment (specifically #8) this is a 
dup of bug 198806.  Saving an image on a page definitely holds 
all of the images on the page till shutdown.

Marking dup

*** This bug has been marked as a duplicate of 198806 ***

Comment 11

[benc]

V/dupe.