Closed Bug 205684 Opened 23 years ago Closed 18 years ago

[ps] PRInt32 nsRenderingContextPS::DrawString(const char *aString, ...) is strange

Categories

(Core :: Printing: Output, defect)

Product:
Core
Component:
Printing: Output
Platform:
x86
BeOS
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

Discussion of silly code as a patch
1.77 KB, patch
Details | Diff | Splinter Review
It creates and fills a dynamically sized transformation matrix but doesn't use it. If the alloc fails then it returns an nsresult, but the function isn't typed as nsresult, it's typed as PRInt32.
Comment on attachment 123295 [details] [diff] [review] Discussion of silly code as a patch I'd just as soon check in the patch with the if 0'd code removed. If someone has bigger ideas for this code, they're welcome to take the bug :).
Attachment #123295 - Flags: review?(smontagu)
Summary: PRInt32 nsRenderingContextPS::DrawString(const char *aString, ...) is strange → [ps] PRInt32 nsRenderingContextPS::DrawString(const char *aString, ...) is strange
Um... so why doesn't the char* code mirror the PRUnichar code?
Zombie bug?
Comment on attachment 123295 [details] [diff] [review] Discussion of silly code as a patch this patch merges cleanly (apply to 1.64 and cvs up -A to 1.85). kherron can you answer neil's question? :)
Attachment #123295 - Flags: review?(kherron+mozilla)
It's zombie now, since the source file was removed in bug 385577.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
Attachment #123295 - Flags: review?(smontagu)
Comment on attachment 123295 [details] [diff] [review] Discussion of silly code as a patch I haven't worked on mozilla in years. Sorry, timeless.
Attachment #123295 - Flags: review?(kherron+mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: