2056928 - Various prefs used to disable preferences UI no longer work with the settings rewrite

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mike Kaply [:mkaply]]

Following up to bug 2055887 where I fixed the homepage button, we have a number of legacy prefs that enterprises use to disable various buttons in prefs:

pref.general.disable_button.default_browser
pref.browser.homepage.disable_button.current_page
pref.browser.homepage.disable_button.bookmark_page
pref.browser.homepage.disable_button.restore_default
pref.privacy.disable_button.view_passwords
security.disable_button.openCertManager
security.disable_button.openDeviceManager
app.update.disable_button.showUpdateHistory
pref.downloads.disable_button.edit_actions
pref.privacy.disable_button.cookie_exceptions
pref.privacy.disable_button.tracking_protection_exceptions
pref.privacy.disable_button.view_passwords_exceptions
pref.advanced.proxies.disable_button.reload
pref.browser.language.disable_button.up
pref.browser.language.disable_button.down

We should make as many of these work again as possible. Customer specifically reported:

pref.downloads.disable_button.edit_actions (Downloads > Files and applications > Action) (bug 2056448: does this need to be reopened?)
pref.privacy.disable_button.view_passwords (Password and autofill > Manage saved passwords) (but it is not critical: disabling password manager looks reasonable alternative.)
pref.privacy.disable_button.cookie_exceptions (Privacy and security > Browsing data > Manage exceptions)
pref.privacy.disable_button.tracking_protection_exceptions (Privacy and security > Enhanced Tracking Protection > Advanced settings > Manage exceptions)

Comment 1

[Mike Kaply [:mkaply]]

Status of each legacy disable_button pref with the settings rewrite:

Fixing in this bug

• pref.privacy.disable_button.cookie_exceptions
• pref.privacy.disable_button.tracking_protection_exceptions
• pref.privacy.disable_button.view_passwords_exceptions
• pref.privacy.disable_button.view_passwords (this one is now a link rather than a button and can't be disabled, so a locked pref hides it instead)
• security.disable_button.openCertManager
• security.disable_button.openDeviceManager
• app.update.disable_button.showUpdateHistory
• pref.downloads.disable_button.edit_actions

Already fixed (bug 2055887):

• pref.general.disable_button.default_browser

Still working, no change needed (these panes/dialogs are still legacy XUL, whose preference= binding continues to disable on lock):

• pref.browser.homepage.disable_button.current_page
• pref.browser.homepage.disable_button.bookmark_page
• pref.browser.homepage.disable_button.restore_default
• pref.advanced.proxies.disable_button.reload
• pref.browser.language.disable_button.up
• pref.browser.language.disable_button.down
• pref.browser.language.disable_button.remove (not in the original list, but exists and works the same as up/down)

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 2056928 - Make legacy disabling pref work with new settings. r?mstriemer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9970c0c6a283
https://hg.mozilla.org/integration/autoland/rev/96c345bde7cf
Make legacy disabling pref work with new settings. r=mstriemer

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/96c345bde7cf

Comment 5

[Phabricator Automation]

firefox-esr153 Uplift Approval Request

• User impact if declined/Reason for urgency: Prefs that used to work stop working in 153
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Only relates to these new locked prefs.
• String changes made/needed?: NOne
• Is Android affected?: no

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Bug 2056928 - Make legacy disabling pref work with new settings.

Original Revision: https://phabricator.services.mozilla.com/D313517

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/e85fb9483a4c