Closed
Bug 205747
Opened 23 years ago
Closed 23 years ago
Add link to serializer-tests document from TestOutSinks.pl
Categories
(Core :: DOM: Serializers, defect)
Core
DOM: Serializers
Tracking
()
RESOLVED
FIXED
mozilla1.4final
People
(Reporter: akkzilla, Assigned: akkzilla)
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
mcafee
:
review+
alecf
:
superreview+
sspitzer
:
approval1.4+
|
Details | Diff | Splinter Review |
When the serializer tests fail in Tinderbox, they should print the url for the
new serializer test howto that I'm about to check in, which will be
http://www.mozilla.org/editor/serializer-tests.html
It includes a section on "What do I do if I broke the tests and need to fix
them, fast?" which I hope will help people diagnosing bustage that shows up from
Tinderbox.
| Assignee | ||
Comment 1•23 years ago
|
||
Print the url in case of error; also change CONVERSION TESTS to SERIALIZER
TESTS.
| Assignee | ||
Comment 2•23 years ago
|
||
Add some potential review victims. (Don't worry, the patch is trivial.)
Setting TM of 1.4 final since it's not a code change to mozilla, only to a
built-time test.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.4final
| Assignee | ||
Updated•23 years ago
|
Attachment #123434 -
Flags: superreview?(alecf)
Attachment #123434 -
Flags: review?(mcafee)
Comment 3•23 years ago
|
||
Comment on attachment 123434 [details] [diff] [review]
Patch: print the url
good idea to print the URL out, r=mcafee.
Attachment #123434 -
Flags: review?(mcafee) → review+
Comment 4•23 years ago
|
||
Comment on attachment 123434 [details] [diff] [review]
Patch: print the url
sr=alecf
Attachment #123434 -
Flags: superreview?(alecf) → superreview+
| Assignee | ||
Comment 5•23 years ago
|
||
Comment on attachment 123434 [details] [diff] [review]
Patch: print the url
Requesting 1.4 approval since I've seen some pending serializer changes which
might land soon (I'm not sure whether those changes are 1.4 approved or not)
and this might help sheriffs or other tree helpers.
Attachment #123434 -
Flags: approval1.4?
Comment 6•23 years ago
|
||
Comment on attachment 123434 [details] [diff] [review]
Patch: print the url
test stuff, no brainer.
Attachment #123434 -
Flags: approval1.4? → approval1.4+
| Assignee | ||
Comment 7•23 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•