205912 - NSS rebuilds too often

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

The current system we have in place for detecting when we should 'make clean' in
NSS greps cvsco.log for updates to NSS on each build.  There are two problems
with this:

- rebuilding from the top will clean and rebuild NSS each time, if NSS was
updated on your last checkout

- if you update your tree again after pulling an NSS update, without building,
you'll miss clobbering NSS entirely.

I've got what I think is a better fix for this.  This patch touches a file in
the source directory after the checkout if any NSS files were updated.  It then
uses a dependency on this file to update a second timestamp file in the object
directory after cleaning NSS.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Attachment: slightly cleaner patch

didn't need the semicolons and continuations in security/manager/Makefile.in,
since these are no longer inside an 'if'.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 123492 [details] [diff] [review]
slightly cleaner patch

In case you're wondering, the rule in security/manager/Makefile.in that can
create .nss.checkout exists so that people's depend builds don't break.  It
shouldn't be necessary in any other case -- .nss.checkout will be included with
source tarballs.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 123492 [details] [diff] [review]
slightly cleaner patch

Can we get this in for 1.4?  Should be pretty safe (zero impact on a clean
build, and we'll know right away if anything breaks).

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 123492 [details] [diff] [review]
slightly cleaner patch

No need for egrep, just use '^[UC] mozilla/security/nss' as the regexp to grep.

But wait, why not do one egrep (need the e here) that greps for '^[UC]
mozilla/security/(nss|coreconf)' instead of two egreps?

Fix that and a=[e-mail] for 1.4.

/be

Comment 6

[Brian Ryner (not reading)]

checked in.

Comment 7

[[e-mail]]

this fix broke the NSS portion of the fast-update script:

/bin/sh: -c: line 2: syntax error: unexpected end of file
make[1]: *** [real_fast-update] Error 2
make[1]: Leaving directory `/home/dwitte/builds/trunk/mozilla'
make: *** [fast-update] Error 2

Comment 8

[Brian Ryner (not reading)]

Checked in a fix for that (missing semicolon).