2059426 - New wpt failures in /svg/coordinate-systems/SVGTransformList.list-01.html

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 61631 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

• /svg/coordinate-systems/SVGTransformList.list-01.html [wpt.fyi]
  • SVGTransformList interface, indexed setter: FAIL

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 2059391 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 2059426 - Add indexed setter to list classes r=emilio

We have this for DOMSVGLengthList but not the other list classes.
See https://www.w3.org/TR/SVG2/types.html#InterfaceSVGNumberList etc.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22287ff38e02
https://hg.mozilla.org/integration/autoland/rev/342a8581ee4b
Add indexed setter to list classes r=emilio,webidl

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/342a8581ee4b

Comment 4

[Robert Longson [:longsonr]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Can now use array indexing to set lists of numbers, points, transforms, strings
[Affects Firefox for Android]: yes
[Suggested wording]:

Lists of numbers, points, transforms and strings can now be set using array indexing instead of needing to use replaceItem. Note that we've supported doing this with lists of lengths and getting an item by an index for some time.

[Links (documentation, blog post, etc)]:

https://developer.mozilla.org/en-US/docs/Web/API/SVGTransformList/replaceItem

old code

transformList.replaceItem(rotateTransform, 0);

new code

transformList[0] = rotateTransform;

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Not convinced this is notable enough for the relnotes (though I'm open to being persuaded otherwise), but at a minimum this should get a dev-doc update.